Skip to content

[Chore] add PR policy and templates#37

Merged
learncold merged 1 commit into
mainfrom
codex/pr-rules
Mar 20, 2026
Merged

[Chore] add PR policy and templates#37
learncold merged 1 commit into
mainfrom
codex/pr-rules

Conversation

@learncold
Copy link
Copy Markdown
Owner

Summary

  • add a repository-level PR guide in CONTRIBUTING.md
  • add a pull request template and CODEOWNERS file
  • add a GitHub Actions PR policy check for title/body requirements

Related Issue

Area

  • Engine
  • Domain
  • Application
  • Docs
  • Build
  • Analysis
  • Chore

Architecture Check

  • I kept the dependency direction application -> domain -> engine.
  • I did not add Qt UI code to src/domain.
  • I did not add domain or application dependencies to src/engine.
  • I used src/ as the include root.

Verification

  • cmake --preset windows-debug
  • cmake --build --preset build-debug
  • Not run (reason below)
  • Local verification focused on repository file changes only.
  • Existing configure step is currently blocked by vcpkg network download failure and a Visual Studio instance mismatch.

Risks / Follow-up

  • The current repository still has src/application, src/domain, and src/engine directories without tracked source files, while CMakeLists.txt references missing C++ files.
  • Branch protection will enforce PR metadata checks, but code build validation should be added after the native source tree is committed and CI prerequisites are stable.

@learncold learncold merged commit 900bc01 into main Mar 20, 2026
1 check passed
@learncold learncold deleted the codex/pr-rules branch March 20, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chore: define PR policy and branch protection

1 participant