Skip to content

[Domain] Add fire and smoke scenario hazards#217

Closed
SilverSupplier wants to merge 5 commits into
mainfrom
codex/hazards-v1-scenario-elements
Closed

[Domain] Add fire and smoke scenario hazards#217
SilverSupplier wants to merge 5 commits into
mainfrom
codex/hazards-v1-scenario-elements

Conversation

@SilverSupplier
Copy link
Copy Markdown
Collaborator

@SilverSupplier SilverSupplier commented May 10, 2026

Summary

  • Add fire/smoke hazards as v1 scenario input elements on EnvironmentState.
  • Persist hazards in project workspace JSON and include them in scenario diff keys.
  • Expose Hazards in scenario authoring with canvas toolbar Fire/Smoke tools that place hazards at specific clicked locations, list edit/delete support, and Smoke visibility-context copy.

Related Issue

Area

  • Engine
  • Domain
  • Application
  • Docs
  • Build
  • Analysis
  • Chore

Architecture Check

  • I kept the dependency direction application -> domain -> engine.
  • I did not add Qt UI code to src/domain.
  • I did not add domain or application dependencies to src/engine.
  • I used src/ as the include root.

Verification

  • cmake --preset windows-debug
  • cmake --build --preset build-debug
  • ctest --preset test-debug
  • Not run (reason below)

All verification commands passed using the Visual Studio bundled CMake/CTest executables because cmake was not on PATH.

Risks / Follow-up

  • Hazards are authoring/persistence inputs only in v1; no fire spread, smoke concentration, FED/FDS, or runtime physics effect is implemented.
  • Runtime interaction, exposure summaries, route-cost effects, and result visualization are intentionally deferred to a separate v2 issue/PR.

@SilverSupplier
Copy link
Copy Markdown
Collaborator Author

검증 업데이트:

  • cmake --preset windows-debug-no-app
  • cmake --build --preset build-no-app-debug
  • ctest --preset test-no-app-debug
  • cmake --preset windows-debug
  • cmake --build --preset build-debug
  • ctest --preset test-debug

Qt 앱 포함 전체 빌드와 테스트까지 통과 확인했습니다.

@SilverSupplier
Copy link
Copy Markdown
Collaborator Author

정리 결정:

Authoring-only v1은 앱 실행 사용자에게 Fire/Smoke가 시뮬레이션 결과에 반영되는 기능처럼 보일 수 있어 standalone PR로 머지하지 않겠습니다. 이 PR의 유효한 범위(authoring/data/persistence/diff)는 #218 v2 통합 작업 안의 #226 foundation 이슈로 흡수합니다.

기존 브랜치와 구현은 참고용으로 보존하고, v2 작업에서는 authoring/data foundation부터 runtime behavior, replay/result visualization까지 한 흐름으로 재구성합니다.

@SilverSupplier
Copy link
Copy Markdown
Collaborator Author

Closed intentionally: standalone authoring-only v1 is being absorbed into #218 via #226 instead of being merged as an isolated feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task-화재/연기 시나리오 입력 요소 v1 구현

1 participant