Skip to content

[Domain] add pressure risk summaries and result view polish #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
95x8x9 wants to merge 2 commits into from
Closed

[Domain] add pressure risk summaries and result view polish #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc325d2
Add pressure risk summaries and overlays
95x8x9 May 9, 2026
18ad9ce
Improve result card label fitting
95x8x9 May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 96 additions & 2 deletions src/application/ScenarioBatchResultWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include <QComboBox>
#include <QEvent>
#include <QFrame>
#include <QHeaderView>
#include <QHBoxLayout>
#include <QLabel>
#include <QMouseEvent>
Expand All @@ -24,6 +25,8 @@
#include <QSizePolicy>
#include <QSlider>
#include <QTabWidget>
#include <QTableWidget>
#include <QTableWidgetItem>
#include <QTimer>
#include <QVBoxLayout>

Expand Down Expand Up @@ -73,6 +76,41 @@ QString formatPercent(std::size_t numerator, std::size_t denominator) {
return QString("%1%").arg(ratio * 100.0, 0, 'f', 0);
}

QString formatPressureScore(double score) {
return QString::number(score, 'f', 1);
}

QTableWidget* createComparisonTable(const QStringList& headers, QWidget* parent) {
auto* table = new QTableWidget(0, headers.size(), parent);
table->setHorizontalHeaderLabels(headers);
table->verticalHeader()->setVisible(false);
table->horizontalHeader()->setStretchLastSection(true);
table->horizontalHeader()->setSectionResizeMode(QHeaderView::Stretch);
table->setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
table->setWordWrap(false);
table->setEditTriggers(QAbstractItemView::NoEditTriggers);
table->setSelectionMode(QAbstractItemView::NoSelection);
table->setFocusPolicy(Qt::NoFocus);
table->setAlternatingRowColors(true);
table->setStyleSheet(
"QTableWidget { background: #ffffff; border: 1px solid #d7e0ea; gridline-color: #e4ebf3; }"
"QHeaderView::section { background: #eef3f8; border: 0; border-bottom: 1px solid #d7e0ea; padding: 6px; color: #4f5d6b; }"
"QTableWidget::item { padding: 6px; }");
return table;
}

QTableWidgetItem* tableItem(const QString& text, bool emphasized = false) {
auto* item = new QTableWidgetItem(text);
item->setFlags(item->flags() & ~Qt::ItemIsEditable);
if (emphasized) {
auto font = item->font();
font.setBold(true);
item->setFont(font);
item->setBackground(QColor("#eef5ff"));
}
return item;
}

QString scenarioRoleLabel(safecrowd::domain::ScenarioRole role) {
switch (role) {
case safecrowd::domain::ScenarioRole::Baseline:
Expand Down Expand Up @@ -658,6 +696,7 @@ QWidget* ScenarioBatchResultWidget::createCanvasPanel() {

overlayCombo_ = new QComboBox(selectorBar);
overlayCombo_->addItem("Density", static_cast<int>(OverlayMode::Density));
overlayCombo_->addItem("Pressure", static_cast<int>(OverlayMode::Pressure));
overlayCombo_->addItem("Hotspots", static_cast<int>(OverlayMode::Hotspots));
overlayCombo_->addItem("Bottlenecks", static_cast<int>(OverlayMode::Bottlenecks));
overlayCombo_->addItem("None", static_cast<int>(OverlayMode::None));
Expand Down Expand Up @@ -704,13 +743,15 @@ QWidget* ScenarioBatchResultWidget::createCanvasPanel() {
auto* tabs = new QTabWidget(graphPanel);
remainingChart_ = new ComparisonGraphWidget(ComparisonGraphMode::Remaining, tabs);
exitsChart_ = new ComparisonGraphWidget(ComparisonGraphMode::Exits, tabs);
pressureTable_ = createComparisonTable({"Scenario", "Peak score", "Exposed / Critical", "Hotspots", "Events", "Peak at"}, tabs);
static_cast<ComparisonGraphWidget*>(remainingChart_)->setResults(results_, selectedCompareIndices_, currentResultIndex_);
static_cast<ComparisonGraphWidget*>(exitsChart_)->setResults(results_, selectedCompareIndices_, currentResultIndex_);
static_cast<ComparisonGraphWidget*>(remainingChart_)->setTimingMarkerActivatedHandler([this](double seconds) {
seekToTimingMarkerSeconds(seconds);
});
tabs->addTab(remainingChart_, "Remaining");
tabs->addTab(exitsChart_, "Exits");
tabs->addTab(pressureTable_, "Pressure");
graphLayout->addWidget(tabs, 1);
layout->addWidget(graphPanel, 1);

Expand Down Expand Up @@ -769,7 +810,7 @@ QWidget* ScenarioBatchResultWidget::createSummaryPanel() {
layout->setContentsMargins(0, 0, 0, 0);
layout->setSpacing(12);

auto* intro = createLabel("Choose which completed scenarios appear together in the Remaining and Exits graphs.", content, ui::FontRole::Caption);
auto* intro = createLabel("Choose which completed scenarios appear together in the comparison graphs and pressure summary table.", content, ui::FontRole::Caption);
intro->setStyleSheet(ui::mutedTextStyleSheet());
layout->addWidget(intro);

Expand Down Expand Up @@ -921,6 +962,12 @@ void ScenarioBatchResultWidget::applyReplayFrameData(const safecrowd::domain::Si
? result.artifacts.densitySummary.peakCells
: result.artifacts.densitySummary.peakField.cells,
result.artifacts.densitySummary.highDensityThresholdPeoplePerSquareMeter);
canvas_->setPressureOverlay(result.artifacts.pressureSummary.peakField.cells.empty()
? result.artifacts.pressureSummary.peakCells
: result.artifacts.pressureSummary.peakField.cells,
std::max(
result.artifacts.pressureSummary.hotspotScoreThreshold,
result.artifacts.pressureSummary.peakPressureScore));
applyOverlayModeToCanvas();
}
if (replaySlider_ != nullptr && replaySlider_->value() != replayFrameIndex_) {
Expand All @@ -946,6 +993,9 @@ void ScenarioBatchResultWidget::applyOverlayModeToCanvas() {
return;
}
switch (overlayMode_) {
case OverlayMode::Pressure:
canvas_->setResultOverlayMode(ResultOverlayMode::Pressure);
break;
case OverlayMode::Hotspots:
canvas_->setResultOverlayMode(ResultOverlayMode::Hotspots);
break;
Expand Down Expand Up @@ -1069,6 +1119,44 @@ void ScenarioBatchResultWidget::refreshComparisonSelection() {
if (exitsChart_ != nullptr) {
static_cast<ComparisonGraphWidget*>(exitsChart_)->setResults(results_, selectedCompareIndices_, currentResultIndex_);
}
refreshPressureComparisonTable();
}

void ScenarioBatchResultWidget::refreshPressureComparisonTable() {
if (pressureTable_ == nullptr) {
return;
}

std::vector<int> visibleIndices = selectedCompareIndices_;
if (visibleIndices.empty() && currentResultIndex_ >= 0 && currentResultIndex_ < static_cast<int>(results_.size())) {
visibleIndices.push_back(currentResultIndex_);
}

pressureTable_->setRowCount(static_cast<int>(visibleIndices.size()));
for (int row = 0; row < static_cast<int>(visibleIndices.size()); ++row) {
const auto index = visibleIndices[static_cast<std::size_t>(row)];
if (index < 0 || index >= static_cast<int>(results_.size())) {
continue;
}

const auto& result = results_[static_cast<std::size_t>(index)];
const auto& summary = result.artifacts.pressureSummary;
const bool emphasized = index == currentResultIndex_;
pressureTable_->setItem(row, 0, tableItem(QString::fromStdString(result.scenario.name), emphasized));
pressureTable_->setItem(row, 1, tableItem(formatPressureScore(summary.peakPressureScore), emphasized));
pressureTable_->setItem(
row,
2,
tableItem(
QString("%1 / %2")
.arg(static_cast<int>(summary.peakExposedAgentCount))
.arg(static_cast<int>(summary.peakCriticalAgentCount)),
emphasized));
pressureTable_->setItem(row, 3, tableItem(QString::number(static_cast<int>(summary.peakHotspots.size())), emphasized));
pressureTable_->setItem(row, 4, tableItem(QString::number(static_cast<int>(summary.criticalEvents.size())), emphasized));
pressureTable_->setItem(row, 5, tableItem(formatSeconds(summary.peakAtSeconds), emphasized));
}
pressureTable_->resizeRowsToContents();
}

void ScenarioBatchResultWidget::refreshResultNavigationPanel() {
Expand Down Expand Up @@ -1151,6 +1239,7 @@ void ScenarioBatchResultWidget::refreshSelectedResult() {
if (exitsChart_ != nullptr) {
static_cast<ComparisonGraphWidget*>(exitsChart_)->setResults(results_, selectedCompareIndices_, currentResultIndex_);
}
refreshPressureComparisonTable();
refreshResultNavigationPanel();
if (detailLabel_ != nullptr) {
const auto selectedFinalSeconds = finalSeconds(result);
Expand All @@ -1159,7 +1248,7 @@ void ScenarioBatchResultWidget::refreshSelectedResult() {
? QString("Baseline")
: formatDeltaSeconds(selectedFinalSeconds - finalSeconds(results_[static_cast<std::size_t>(baselineIndex)])))
: QString("No baseline");
detailLabel_->setText(QString("%1 (%2)\nFinal: %3\nDelta vs baseline: %4\nEvacuated: %5 / %6 (%7)\nRisk: %8\nHotspots: %9\nBottlenecks: %10\nT90 / T95: %11 / %12")
detailLabel_->setText(QString("%1 (%2)\nFinal: %3\nDelta vs baseline: %4\nEvacuated: %5 / %6 (%7)\nRisk: %8\nHotspots: %9\nBottlenecks: %10\nPressure hotspots: %11\nCritical pressure: %12 agents / %13 events\nPeak pressure: %14 at %15\nT90 / T95: %16 / %17")
.arg(QString::fromStdString(result.scenario.name))
.arg(scenarioRoleLabel(result.scenario.role))
.arg(formatSeconds(selectedFinalSeconds))
Expand All @@ -1170,6 +1259,11 @@ void ScenarioBatchResultWidget::refreshSelectedResult() {
.arg(safecrowd::domain::scenarioRiskLevelLabel(result.risk.completionRisk))
.arg(static_cast<int>(result.risk.hotspots.size()))
.arg(static_cast<int>(result.risk.bottlenecks.size()))
.arg(static_cast<int>(result.artifacts.pressureSummary.peakHotspots.size()))
.arg(static_cast<int>(result.artifacts.pressureSummary.peakCriticalAgentCount))
.arg(static_cast<int>(result.artifacts.pressureSummary.criticalEvents.size()))
.arg(formatPressureScore(result.artifacts.pressureSummary.peakPressureScore))
.arg(formatSeconds(result.artifacts.pressureSummary.peakAtSeconds))
.arg(formatSeconds(result.artifacts.timingSummary.t90Seconds))
.arg(formatSeconds(result.artifacts.timingSummary.t95Seconds)));
}
Expand Down
10 changes: 7 additions & 3 deletions src/application/ScenarioBatchResultWidget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class QCheckBox;
class QComboBox;
class QPushButton;
class QSlider;
class QTableWidget;
class QTimer;

namespace safecrowd::application {
Expand Down Expand Up @@ -45,9 +46,10 @@ class ScenarioBatchResultWidget : public QWidget {
private:
enum class OverlayMode {
Density = 0,
Hotspots = 1,
Bottlenecks = 2,
None = 3,
Pressure = 1,
Hotspots = 2,
Bottlenecks = 3,
None = 4,
};

QWidget* createCanvasPanel();
Expand All @@ -61,6 +63,7 @@ class ScenarioBatchResultWidget : public QWidget {
void navigateToAuthoring();
void pauseReplay();
void refreshComparisonSelection();
void refreshPressureComparisonTable();
void refreshResultNavigationPanel();
void refreshSelectedResult();
void rerunBatch();
Expand Down Expand Up @@ -89,6 +92,7 @@ class ScenarioBatchResultWidget : public QWidget {
QSlider* replaySlider_{nullptr};
QLabel* replayTimeLabel_{nullptr};
QLabel* detailLabel_{nullptr};
QTableWidget* pressureTable_{nullptr};
std::vector<QCheckBox*> compareCheckBoxes_{};
QWidget* remainingChart_{nullptr};
QWidget* exitsChart_{nullptr};
Expand Down
Loading
Loading