Skip to content

[Application] Fix scenario panel scroll behavior#205

Merged
learncold merged 2 commits into
mainfrom
codex/scenario-panel-scroll-fix
May 9, 2026
Merged

[Application] Fix scenario panel scroll behavior#205
learncold merged 2 commits into
mainfrom
codex/scenario-panel-scroll-fix

Conversation

@95x8x9
Copy link
Copy Markdown
Collaborator

@95x8x9 95x8x9 commented May 8, 2026

Summary

  • Keep the scenario overview and changes cards visually stable by preserving fixed outer card frames while scrolling only the card contents.
  • Let the overview and changes sections shrink first and only enable internal vertical scrolling after their minimum heights are reached.
  • Prevent the Run section from expanding to consume leftover panel height so the right panel follows the original layout more closely.

Related Issue

  • None (application-only PR)

Area

  • Engine
  • Domain
  • Application
  • Docs
  • Build
  • Analysis
  • Chore

Architecture Check

  • I kept the dependency direction application -> domain -> engine.
  • I did not add Qt UI code to src/domain.
  • I did not add domain or application dependencies to src/engine.
  • I used src/ as the include root.

Verification

  • cmake --preset windows-debug
  • cmake --build --preset build-debug
  • ctest --preset test-debug
  • Not run (reason below)
  • Verified with cmake --build --preset build-debug --target safecrowd_app

Risks / Follow-up

  • Right panel sizing and scroll behavior should still be checked once in the app with narrow vertical space to confirm the cards begin scrolling only after the minimum heights are reached.
  • This PR intentionally excludes unrelated local changes in src/application/ProjectPersistence.cpp.

@95x8x9 95x8x9 marked this pull request as ready for review May 8, 2026 15:09
@95x8x9 95x8x9 requested a review from learncold as a code owner May 8, 2026 15:09
…scroll-fix

# Conflicts:
#	src/application/ScenarioAuthoringWidget.cpp
@learncold learncold merged commit 785c262 into main May 9, 2026
2 checks passed
@learncold learncold deleted the codex/scenario-panel-scroll-fix branch May 9, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants