[Application] Preserve scenario authoring state#201
Closed
SilverSupplier wants to merge 3 commits into
Closed
Conversation
Move scenario duplication logic out of the widget into the domain layer and compute variationDiffKeys from the actual baseline-vs-variant field delta instead of a hardcoded "branch.duplicated" marker. - domain: duplicateScenarioDraft, computeScenarioDiffKeys (new ScenarioAuthoring.cpp). - application: ScenarioAuthoringWidget delegates duplication to the domain helper, recomputes variationDiffKeys on every mutation point (placements, events, connection blocks), and shows the keys in the inspector instead of synthetic counters. - tests: ScenarioAuthoringTests covering deep copy, source preservation, and per-field diff detection. Refs #188, #189.
Collaborator
Author
|
Closing in favor of #193; the review branch changes have been applied to feature/us-06-scenario-duplication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main.Related Issue
Area
Architecture Check
application -> domain -> engine.src/domain.domainorapplicationdependencies tosrc/engine.src/as the include root.Verification
cmake --preset windows-debugcmake --build --preset build-debugctest --preset test-debugRisks / Follow-up