[Domain] 연결선 위치 정합성 검증#191
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connection2D.centerSpan)이fromZoneId/toZoneId로 참조하는 실제 구역 경계와 맞닿는지 검증을 추가한다.InvalidGeometryblocking issue를 생성한다.InvalidGeometry를 live validation issue로 분류해, 사용자가 연결선을 정상 위치로 되돌리면 기존 blocking issue가 사라지도록 한다.Related Issue
Area
Architecture Check
application -> domain -> engine.src/domain.domainorapplicationdependencies tosrc/engine.src/as the include root.Verification
cmake --preset windows-debugcmake --preset windows-debug-no-appcmake --build --preset build-debug --target safecrowd_testscmake --build --preset build-no-app-debug --target safecrowd_testsctest --preset test-debugctest --preset test-no-app-debugRisks / Follow-up
InvalidGeometrylive validation refresh를 위해 application layer의 issue 갱신 목록도 함께 업데이트했다.