[Application] Seek replay to exact T90/T95#181
Merged
Conversation
Remove specific directories from .gitignore
learncold
requested changes
May 5, 2026
Owner
learncold
left a comment
There was a problem hiding this comment.
T90/T95 클릭 replay 기능의 방향은 맞지만, 현재 키프레임 저장 시점 때문에 '정확한 T90/T95' 상태를 보장하지 못합니다. 아래 코멘트의 frame capture 위치를 수정한 뒤 다시 확인하는 것이 좋겠습니다.
Collaborator
Author
|
리뷰 코멘트 반영했습니다.\n\n- T90/T95 키프레임 캡처를 RenderSync(ScenarioFrameSyncSystem)에서 제거하고, evac 완료 전환 감지 시점(ScenarioSimulationMotionSystem)에서 바로 frame을 캡처하도록 변경했습니다.
|
learncold
approved these changes
May 5, 2026
Owner
learncold
left a comment
There was a problem hiding this comment.
수정 반영 확인했습니다. T90/T95 키프레임을 evacuation 완료 전환 감지 시점에서 캡처하도록 변경되어, 기존에 지적한 시간/상태 불일치 문제가 해결됐습니다.
확인:
cmake --preset windows-debug-no-appcmake --build --preset build-no-app-debug --target safecrowd_testsctest --preset test-no-app-debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Area
Architecture Check
application -> domain -> engine.src/domain.domainorapplicationdependencies tosrc/engine.src/as the include root.Verification
cmake --preset windows-debugcmake --build --preset build-debugctest --preset test-debugcmake --build --preset build-no-app-debug --target safecrowd_testsctest --preset test-no-app-debugRisks / Follow-up