This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Reveal git error messages on clone/fork fail, enforce Github username#41
Open
louisrli wants to merge 2 commits intolearn-co:masterfrom
Open
Reveal git error messages on clone/fork fail, enforce Github username#41louisrli wants to merge 2 commits intolearn-co:masterfrom
louisrli wants to merge 2 commits intolearn-co:masterfrom
Conversation
Author
|
can someone look at this pr |
Author
|
ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all, I'm teaching a coding bootcamp for Re:Coded that uses learn.co. Some students are getting tripped up by obscure error messages about being unable to clone, and it's hard for us to diagnose the issue based on the current error message
This pull requests does two things:
@organizationcan be parsed and is non-empty as a result. If it is empty, it suggests that the user link a Github account (perhaps there's a better place to do this, the maintainer can decide)Note that there is an additional bug that's not being addressed, which is that the "forking logic" passes successfully even when there is no Github account, but despite nothing actually being forked. For this, I've filed #40
(The root issue is the setup documentation: none of the Mac, Linux, or Windows instructions say that linking your Github account is required, e.g., this link does not say you must link your Github account. https://github.com/learn-co-curriculum/wsl-setup)