Skip to content

Minor edits#13

Open
lizbur10 wants to merge 1 commit into
masterfrom
js-update
Open

Minor edits#13
lizbur10 wants to merge 1 commit into
masterfrom
js-update

Conversation

@lizbur10

Copy link
Copy Markdown
Contributor

Major updates to existing lesson

@jlboba jlboba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread README.md
it will make your code clearer.
2. `reduce()` will automatically pass two arguments when it calls your reducer
function: the current element of the array and the current value of the
accumulator. Your function needs to accept those two values as parameters,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe specify "Your reducer function..." or "Your callback function..." here

Comment thread README.md
```js
artsShowcases["Visual"]; //=> [yishayGarbasz, wuTsang, mickaleneThomas]
```
**TAKE OUT LAB PORTION?**

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would agree with this, but I generally think labs/lessons should be separated. Maybe we should discuss this in a more general sense?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree it may be easier on students to review lesson content and have labs separately that way they can take a break and not get overwhelmed with reading and immediately doing a lab. This is also a good way of "chunking" content in the program to avoid cognitive overload on students

Comment thread README.md

To see what this might look like, let's count the number of coupons we have
lying around the house:
What if we wanted to calculate something else, say, the number of coupons we

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great built in check for understanding question!

Comment thread README.md
```js
artsShowcases["Visual"]; //=> [yishayGarbasz, wuTsang, mickaleneThomas]
```
**TAKE OUT LAB PORTION?**

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree it may be easier on students to review lesson content and have labs separately that way they can take a break and not get overwhelmed with reading and immediately doing a lab. This is also a good way of "chunking" content in the program to avoid cognitive overload on students

Comment thread README.md
- Learn how the `reduce()` method works
- Demonstrate using `reduce()` with a primitive return value
- Demonstrate using `reduce()` with an object as the return value
- Learn how the `Array.prototype.reduce()` method works

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recognize how the Array.prototype.reduce() method works.

@linda-seiter linda-seiter left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: step through a debug session showing the calls to reduce() and couponCounter() for the manually implemented version (or show a table of function calls with parameter values).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants