filter-methd-lab#21
Open
BarkleyRhoat wants to merge 4 commits into
Open
Conversation
BarkleyRhoat
commented
May 7, 2026
BarkleyRhoat
commented
KFad11
approved these changes
May 8, 2026
KFad11
left a comment
KFad11
left a comment
There was a problem hiding this comment.
Super clean! I don't mind the .startsWith() here, good idea.
The small miss I would point out is the tests stand up the drivers array and clear it out before the examples and .push a fresh list of them back in every time. So we didn't need to define the collection array of objects here. We could have omitted that definition at the top and been totally fine based on the test setup I described.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.