feat: support cancellation of RPC requests #700
+188
−69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for cancelling LSP and RPC requests in infoview code (including widgets). No changes to Lean are needed since the server already handles
$/cancelRequest, andRequestMincludes checkCancelled.Main changes:
AbortSignalargument to LSP and RPC calls. Aborting causes the request to be cancelled which sets theRequestContext.cancelTkat the server end.EditorApiinto a serializableEditorRpicApiand a (non-serializable)EditorApiwrapper for use in the infoview. This is necessary becauseAbortSignalcannot simply be sent over to the editor.Disposablesubscriptions ininfoview.tsa bit.This spun out of leanprover-community/ProofWidgets4#141 which hand-rolls support for cancelling widget requests. However, it is challenging to ensure that computations are cancelled when the infoview closes, for example, without changing the extension. I also think it is better to use builtin mechanisms already present in
RequestMthan to implement our own.