Skip to content

feat: Kronecker delta api#979

Open
gloges wants to merge 11 commits intoleanprover-community:masterfrom
gloges:kronecker-delta
Open

feat: Kronecker delta api#979
gloges wants to merge 11 commits intoleanprover-community:masterfrom
gloges:kronecker-delta

Conversation

@gloges
Copy link
Contributor

@gloges gloges commented Mar 8, 2026

Introduces a basic api for the Kronecker delta function.

  • I've kept to lemmas which adhere to the Einstein summation rules that indices occur at most twice in each term and free indices match across = (unless one side is zero). Hence no δ[i,j] • f i j = δ[i,j] • f i i lemma.
  • Commutators.lean and LaplaceRungeLenzVector.lean required some fixes, which I have done crudely (w/ sorries for some of the more computation-heavy lemmas); I will revisit these soon.

@morrison-daniel morrison-daniel self-assigned this Mar 8, 2026
Copy link
Collaborator

@morrison-daniel morrison-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few style points for now, I'll take a deeper look soon.

@morrison-daniel morrison-daniel added t-mathematics Mathematics awaiting-author A reviewer has asked the author a question or requested changes merge-conflict The PR has a merge conflict with master labels Mar 10, 2026
@gloges
Copy link
Contributor Author

gloges commented Mar 10, 2026

I've cleaned up the lemma names and added (double) sums over finite subsets. After the merge, needed to add @[expose] public section to fix some errors.

@zhikaip
Copy link
Collaborator

zhikaip commented Mar 10, 2026

You could remove the awaiting author and merge-conflict tags to let the reviewers know when the PR is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes merge-conflict The PR has a merge conflict with master t-mathematics Mathematics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants