Merged
Conversation
jstoobysmith
added
t-space-time
Member
Author
|
Put |
Member
Author
|
There is a lot here to review, but most of it is old code that has just been moved (e.g. everything in the Module file is existing code). What is actually new is the definition of |
jstoobysmith
removed
the
awaiting-author
Thanks to @YanYablonovskiy for pointing this out.
morrison-daniel
approved these changes
Mar 6, 2026
Collaborator
morrison-daniel
left a comment
morrison-daniel
left a comment
There was a problem hiding this comment.
I think it's smart to separate the general properties of Space from those that depend on a choice of origin and therefore module structure.
morrison-daniel
added
the
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an
AddTorsorinstance onSpace dalong with a number of other little results which are required to define this