feat: typeclass for zero-dimensional spaces#37444
feat: typeclass for zero-dimensional spaces#37444vihdzp wants to merge 8 commits intoleanprover-community:masterfrom
Conversation
vihdzp
commented
Mar 31, 2026
- depends on: feat: a topology with a basis of clopens is completely regular #37317
PR summary 4ec5d95aa6Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Topology.UniformSpace.Ultra.Basic | 618 | 705 | +87 (+14.08%) |
| Mathlib.Topology.Separation.CompletelyRegular | 1550 | 1552 | +2 (+0.13%) |
| Mathlib.Topology.Separation.Lemmas | 1554 | 1555 | +1 (+0.06%) |
Import changes for all files
| Files | Import difference |
|---|---|
5 filesMathlib.MeasureTheory.Measure.DiracProba Mathlib.MeasureTheory.Measure.LevyConvergence Mathlib.MeasureTheory.Measure.Prokhorov Mathlib.Probability.CentralLimitTheorem Mathlib.Topology.Separation.Lemmas |
1 |
5 filesMathlib.Topology.MetricSpace.Snowflaking Mathlib.Topology.Separation.CompletelyRegular Mathlib.Topology.UniformSpace.Ultra.Completion Mathlib.Topology.UniformSpace.Ultra.Constructions Mathlib.Topology.UniformSpace.Uniformizable |
2 |
Mathlib.Topology.UniformSpace.Ultra.Basic |
87 |
Declarations diff
+ CompletelyRegularSpace.of_isTopologicalBasis_clopens
+ CompletelyRegularSpace.totallySeparatedSpace_of_cardinalMk_lt_continuum
+ CompletelyRegularSpace.zeroDimensionalSpace_of_cardinalMk_lt_continuum
+ IndiscreteTopology.isClopen_iff
+ ZeroDimensionalSpace
+ ZeroDimensionalSpace.of_isOpen_of_nhds
+ exists_isClopen_mem_of_isOpen
+ hasBasis_nhds_isClopen
+ instance : ZeroDimensionalSpace X := by
+ instance [Countable X] [T35Space X] : TotallySeparatedSpace X
+ instance [DiscreteTopology X] : ZeroDimensionalSpace X := by
+ instance [IndiscreteTopology X] : ZeroDimensionalSpace X := by
+ instance [T0Space X] [ZeroDimensionalSpace X] : TotallySeparatedSpace X := by
+ instance [T2Space X] [CompactSpace X] [TotallyDisconnectedSpace X] : ZeroDimensionalSpace X := by
+ instance [TotallyDisconnectedSpace H] : ZeroDimensionalSpace H := by
+ instance [ZeroDimensionalSpace X] : CompletelyRegularSpace X
+ totallyDisconnectedSpace_iff_totallySeparatedSpace
- _root_.Set.Countable.totallySeparatedSpace
- _root_.TopologicalSpace.isTopologicalBasis_clopens
- instance (priority := 100) [TotallyDisconnectedSpace H] : TotallySeparatedSpace H
- instance [Countable X] : TotallySeparatedSpace X
- totallySeparatedSpace_of_cardinalMk_lt_continuum
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
Increase in tech debt: (relative, absolute) = (1.00, 0.00)
| Current number | Change | Type |
|---|---|---|
| 454 | 1 | porting notes |
Current commit 11eee01e7e
Reference commit 4ec5d95aa6
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
This PR/issue depends on:
|
|
I wonder, what happens with the class |
|
I figured it could be similar to how we have |
|
I see. If you're ok with it I can implement |
|
Go for it! As long as the definition doesn't use too many imports, and as long as we have |