feat: add coe instances for spectrums#37343
Open
xgenereux wants to merge 1 commit intoleanprover-community:masterfrom
Open
feat: add coe instances for spectrums#37343xgenereux wants to merge 1 commit intoleanprover-community:masterfrom
xgenereux wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary c00fe67bb4Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Contributor
|
Can you add a bit of description to the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
Coeinstances for the typePrimeSpectrumand similar.For
P: PrimeSpectrum, this means that when lean expectsIdeal A, we can directly writeP : Ideal Ainstead ofP.asIdeal. The.asIdealgets inserted automatically.At the moment, I haven't set up the
@[coe]to make delab into↑P- it simply showsP.asIdealin the infoview. If we want the↑PI can add it.