Skip to content

chore(Tactic/FunProp): reword failure hint#37339

Open
SnirBroshi wants to merge 1 commit intoleanprover-community:masterfrom
SnirBroshi:patch-2
Open

chore(Tactic/FunProp): reword failure hint#37339
SnirBroshi wants to merge 1 commit intoleanprover-community:masterfrom
SnirBroshi:patch-2

Conversation

@SnirBroshi
Copy link
Copy Markdown
Collaborator

@SnirBroshi SnirBroshi commented Mar 29, 2026

Reword Maybe you forgot marking `{decl}` with `@[fun_prop]`. to Consider marking `{decl}` with `@[fun_prop]`..


The current wording sounds strange to me.

Alternatives:

  • "Consider tagging ..."
  • "Maybe you forgot to mark ..."
  • "Maybe you forgot to tag ..."
  • "Try marking ..."
  • "Try tagging ..."

Open in Gitpod

@SnirBroshi SnirBroshi requested a review from Vierkantor March 29, 2026 16:36
@SnirBroshi SnirBroshi added the easy < 20s of review time. See the lifecycle page for guidelines. label Mar 29, 2026
@github-actions
Copy link
Copy Markdown

PR summary 5ee50502f9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-meta Tactics, attributes or user commands label Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants