Skip to content

[Merged by Bors] - feat(AlgebraicTopology/SimplicialSet): induction principles for nondegenerate simplices#37335

Closed
joelriou wants to merge 8 commits intoleanprover-community:masterfrom
joelriou:nondegenerate-simplices-induction
Closed

[Merged by Bors] - feat(AlgebraicTopology/SimplicialSet): induction principles for nondegenerate simplices#37335
joelriou wants to merge 8 commits intoleanprover-community:masterfrom
joelriou:nondegenerate-simplices-induction

Conversation

@joelriou
Copy link
Copy Markdown
Contributor


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2026

PR summary 2e36a1dbb4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ cases
+ dim_toN_le
+ eq_iff_ofSimplex_eq
+ eq_iff_sMk_eq
+ existsN
+ existsUnique_toNπ
+ induction
+ induction_mk
+ instance (x : X.S) : Epi x.toNπ := (existsUnique_toNπ rfl).exists.choose_spec.1
+ map_toNπ_op_apply
+ ofSimplex_eq_subcomplex_mk
+ subcomplex_cast
+ subcomplex_eq_of_epi
+ subcomplex_le_iff
+ subcomplex_map_le
+ toNπ
++ lt_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
6902 1 backward.isDefEq.respectTransparency

Current commit 84d41f7a95
Reference commit 2e36a1dbb4

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@robin-carlier robin-carlier added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
joelriou and others added 7 commits April 3, 2026 10:54
…Subcomplex.lean

Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
….lean

Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
….lean

Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
….lean

Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
….lean

Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
….lean

Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
@joelriou
Copy link
Copy Markdown
Contributor Author

joelriou commented Apr 3, 2026

Thanks @robin-carlier for the reviews!

Copy link
Copy Markdown
Contributor

@robin-carlier robin-carlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 3, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 4, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 4, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 4, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(AlgebraicTopology/SimplicialSet): induction principles for nondegenerate simplices [Merged by Bors] - feat(AlgebraicTopology/SimplicialSet): induction principles for nondegenerate simplices Apr 4, 2026
@mathlib-bors mathlib-bors bot closed this Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebraic-topology Algebraic topology

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants