Skip to content

feat(AlgebraicTopology/SimplicialSet): more API for horns#37333

Open
joelriou wants to merge 3 commits intoleanprover-community:masterfrom
joelriou:sset-horn
Open

feat(AlgebraicTopology/SimplicialSet): more API for horns#37333
joelriou wants to merge 3 commits intoleanprover-community:masterfrom
joelriou:sset-horn

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Mar 29, 2026

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2026

PR summary 35bf175a46

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ face_le_horn_iff
+ horn_obj_eq_top
+ instance {n : ℕ} (i : Fin (n + 1)) : HasDimensionLT (horn.{u} n i) n := by
+ mem_horn_iff
+ objEquiv_symm_notMem_horn_of_isIso
+ objEquiv_symm_δ_mem_horn_iff
+ objEquiv_symm_δ_notMem_horn_iff
+ subcomplex_le_horn_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
6917 1 backward.isDefEq.respectTransparency

Current commit 759d0869be
Reference commit 35bf175a46

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Mar 29, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

@joelriou joelriou added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebraic-topology Algebraic topology

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants