[Merged by Bors] - chore: minor edits to GNS construction files

[gw90]

---

Fixing a typo in a docstring and making some edits for concision. No API changes.

[github-actions]

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

[github-actions]

PR summary b301d257a1

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

---

Declarations diff

+ completion_leftMulMapPreGNS_map_smul

You can run this locally as follows

## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

---

Increase in tech debt: (relative, absolute) = (1.00, 0.00)

Current number	Change	Type
6896	1	backward.isDefEq

Current commit ebb8569725
Reference commit b301d257a1

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary

• The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
• The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

[themathqueen]

I know it's private so it doesn't matter as much, but probably completion_leftMulMapPreGNS_map_smul is a more appropriate name?

[gw90]

How about leftMulMapPreGNS_completion_map_smul? It just matches more closely with the theorem statement.

[themathqueen]

I don't think so? Remember (f.leftMulMapPreGNS ...).completion is really ContinuousLinearMap.completion (f.leftMulMapPreGNS ...). The naming generally follows that and not the dot notation.

[gw90]

Ok, but the wouldn't that reasoning also apply to ContinuousLinearMap.toAddMonoidHom_completion? Or is it fine there because the theorem is stating that toAddMonoidHom and completion can basically be applied in either order?

[themathqueen]

No, ContinuousLinearMap.toAddMonoidHom_completion is right: it's basically LinearMap.toAddMonoidHom (ContinuousLinearMap.completion f) = .... The takeaway is, when you're naming a lemma, don't look at it with dot notation.

[j-loreaux]

But note that the community is currently divided on this issue, and we haven't come to a final decision about how to name things. There are arguments in both directions.

[j-loreaux]

Thanks!

bors merge

[mathlib-bors]

Pull request successfully merged into master.

Build succeeded:

• ci (staging) / Post-CI job
• ci (staging) / Post-Build Step
• ci (staging) / Build
• ci (staging) / Lint style