chore(LinearAlgebra/Complex/Module): add Algebra ℝ ℂ shortcut instance#37318
Open
JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
Open
chore(LinearAlgebra/Complex/Module): add Algebra ℝ ℂ shortcut instance#37318JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
Algebra ℝ ℂ shortcut instance#37318JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary 15f863238cImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 7341 | -1 | backward.isDefEq |
Current commit 2c5f7834db
Reference commit 15f863238c
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by Kevin: https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/linter.20for.20instance.20diamonds/near/582324014
This help make sure that we get the "right" instance. However, ideally we would want to fix the problem of having "wrong" instances in the first place.