Skip to content

chore: use more inferInstanceAs#37315

Open
sgouezel wants to merge 2 commits intoleanprover-community:masterfrom
sgouezel:SG_lintMore
Open

chore: use more inferInstanceAs#37315
sgouezel wants to merge 2 commits intoleanprover-community:masterfrom
sgouezel:SG_lintMore

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2026

PR summary 0e301e814c

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Data.Prod.Lex 172 173 +1 (+0.58%)
Import changes for all files
Files Import difference
4 files Mathlib.Algebra.Order.Monoid.Lex Mathlib.Algebra.Order.Monoid.Prod Mathlib.Data.Prod.Lex Mathlib.Order.Prod.Lex.Hom
1

Declarations diff

+ instance [AddCommGroup α] : AddCommGroup (Holor α ds)
+ instance [AddCommMonoid α] : AddCommMonoid (Holor α ds)
+ instance [AddCommSemigroup α] : AddCommSemigroup (Holor α ds)
+ instance [AddGroup α] : AddGroup (Holor α ds)
+ instance [AddMonoid α] : AddMonoid (Holor α ds)
+ instance [AddSemigroup α] : AddSemigroup (Holor α ds)
+ instance [Semiring α] : Module α (Holor α ds)
- instCompleteAtomicBooleanAlgebra
- instance [AddCommGroup α] : AddCommGroup (Holor α ds) := Pi.addCommGroup
- instance [AddCommMonoid α] : AddCommMonoid (Holor α ds) := Pi.addCommMonoid
- instance [AddCommSemigroup α] : AddCommSemigroup (Holor α ds) := Pi.addCommSemigroup
- instance [AddGroup α] : AddGroup (Holor α ds) := Pi.addGroup
- instance [AddMonoid α] : AddMonoid (Holor α ds) := Pi.addMonoid
- instance [AddSemigroup α] : AddSemigroup (Holor α ds) := Pi.addSemigroup
- instance [Semiring α] : Module α (Holor α ds) := Pi.module _ _ _

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant