[Merged by Bors] - chore(Analysis/Normed/Module/WeakDual): revert polar, polar_def and isClosed_polar to weaker hypotheses#37314
Conversation
PR summary 63486b57caImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
themathqueen
left a comment
There was a problem hiding this comment.
Pretty sure you're going to need to add those back?
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
|
@JonBannon the shuffling in the
but you've changed it to:
This is bad because it's mixing semantic content just to switch some section variables. If this file were to be split (as could potentially eventually happen), the "right" split would be into |
themathqueen
left a comment
There was a problem hiding this comment.
Thanks! Let's just have another pair of eyes on this to make sure I didn't overlook anything.
maintainer delegate?
|
🚀 Pull request has been placed on the maintainer queue by themathqueen. |
…nd `isClosed_polar` to weaker hypotheses (#37314) The three results mentioned inadvertently had their hypotheses strengthened in [#36332](#36332). This PR recovers generality. In addition, I have globalized variables to guard against this issue happening again and have moved part of a file that does not require `NontriviallyNormedField k` to Topology/Algebra/Module/WeakDual.
|
Pull request successfully merged into master. Build succeeded: |
polar, polar_def and isClosed_polar to weaker hypothesespolar, polar_def and isClosed_polar to weaker hypotheses
The three results mentioned inadvertently had their hypotheses strengthened in #36332. This PR recovers generality.
In addition, I have globalized variables to guard against this issue happening again and have moved part of a file that does not require
NontriviallyNormedField kto Topology/Algebra/Module/WeakDual.