Skip to content

[Merged by Bors] - chore(Analysis/Normed/Module/WeakDual): revert polar, polar_def and isClosed_polar to weaker hypotheses#37314

Closed
JonBannon wants to merge 30 commits intoleanprover-community:masterfrom
JonBannon:Revert-polar,-polar_def-and-isClosed_polar
Closed

[Merged by Bors] - chore(Analysis/Normed/Module/WeakDual): revert polar, polar_def and isClosed_polar to weaker hypotheses#37314
JonBannon wants to merge 30 commits intoleanprover-community:masterfrom
JonBannon:Revert-polar,-polar_def-and-isClosed_polar

Conversation

@JonBannon
Copy link
Copy Markdown
Collaborator

@JonBannon JonBannon commented Mar 28, 2026

The three results mentioned inadvertently had their hypotheses strengthened in #36332. This PR recovers generality.
In addition, I have globalized variables to guard against this issue happening again and have moved part of a file that does not require NontriviallyNormedField k to Topology/Algebra/Module/WeakDual.


Open in Gitpod

@JonBannon JonBannon requested a review from themathqueen March 28, 2026 12:52
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2026

PR summary 63486b57ca

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@JonBannon JonBannon requested a review from j-loreaux March 28, 2026 12:52
@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Mar 28, 2026
@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 29, 2026
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure you're going to need to add those back?

@themathqueen themathqueen added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Mar 29, 2026
@themathqueen themathqueen removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 30, 2026
@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 30, 2026
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
JonBannon and others added 3 commits March 31, 2026 10:50
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
JonBannon and others added 3 commits March 31, 2026 11:12
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
@JonBannon JonBannon removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 31, 2026
@j-loreaux
Copy link
Copy Markdown
Contributor

@JonBannon the shuffling in the Topology.Algebra.Module.WeakDual file is suboptimal. IThe file structure used to be like this:

  • WeakDual
    • Semiring
    • Ring
  • WeakSpace
    • Semiring
    • Ring

but you've changed it to:

  • Semiring
    • WeakDual
    • WeakSpace
  • Ring
    • WeakDual
    • WeakSpace

This is bad because it's mixing semantic content just to switch some section variables. If this file were to be split (as could potentially eventually happen), the "right" split would be into WeakSpace and WeakDual, not into Semiring and Ring, so by doing this shuffling you're hurting the organization of the file.

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 31, 2026
@JonBannon JonBannon removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 1, 2026
Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's just have another pair of eyes on this to make sure I didn't overlook anything.

maintainer delegate?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

🚀 Pull request has been placed on the maintainer queue by themathqueen.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 3, 2026
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 3, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 3, 2026
…nd `isClosed_polar` to weaker hypotheses (#37314)

The three results mentioned inadvertently had their hypotheses strengthened in [#36332](#36332). This PR recovers generality.
In addition, I have globalized variables to guard against this issue happening again and have moved part of a file that does not require `NontriviallyNormedField k` to Topology/Algebra/Module/WeakDual.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 3, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Analysis/Normed/Module/WeakDual): revert polar, polar_def and isClosed_polar to weaker hypotheses [Merged by Bors] - chore(Analysis/Normed/Module/WeakDual): revert polar, polar_def and isClosed_polar to weaker hypotheses Apr 3, 2026
@mathlib-bors mathlib-bors bot closed this Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants