-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Merged by Bors] - feat(Tactic/ComputeAsymptotics/Multiseries): non-primitive corecursion for Seq: FriendlyOperation API
#35072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
vasnesterov
wants to merge
16
commits into
leanprover-community:master
from
vasnesterov:compute_asymptotics_corecursion_2
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e96537b
more corecursion
vasnesterov 91e43cf
op_head_eq
vasnesterov ecc2cd0
suggestions
vasnesterov b8f0aaf
docstrings
vasnesterov 7a46950
Merge branch 'master' into compute_asymptotics_corecursion_2
vasnesterov d507e63
remove commented line
vasnesterov 6f2b56b
remove file
vasnesterov a7a71cd
suggestions
vasnesterov e6253c1
suggestions
vasnesterov 482d31a
Merge branch 'master' into compute_asymptotics_corecursion_2
vasnesterov a47d79d
respectTransparency
vasnesterov 4864dad
suggestions
vasnesterov 478b06d
split
vasnesterov 3727af3
Merge branch 'master' into compute_asymptotics_corecursion_2
vasnesterov 3f407b0
use dist_le_half_iff
vasnesterov 2ba6668
Merge branch 'master' into compute_asymptotics_corecursion_2
vasnesterov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vasnesterov to get some movement on merging your work, could I suggest that we split this PR here at this point (again)? I think everything above could be approved quite directly, while the remainder still contains some heavy, long proofs.
I doubt that a maintainer will get around looking at the entire PR, but if we split it here, I think we might improve the changes of getting some progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. The second part is in #37342