Skip to content

[Merged by Bors] - feat(Combinatorics/SimpleGraph/Basic): decidability instance for fromRel.Adj#33798

Closed
Paul-Lez wants to merge 3 commits intoleanprover-community:masterfrom
Paul-Lez:decidability-from-rel
Closed

[Merged by Bors] - feat(Combinatorics/SimpleGraph/Basic): decidability instance for fromRel.Adj#33798
Paul-Lez wants to merge 3 commits intoleanprover-community:masterfrom
Paul-Lez:decidability-from-rel

Conversation

@Paul-Lez
Copy link
Copy Markdown
Collaborator

@Paul-Lez Paul-Lez commented Jan 9, 2026

This might be better as a definition - I'll let the reviewers weigh in on this.


Open in Gitpod

@Paul-Lez Paul-Lez requested a review from YaelDillies January 9, 2026 16:56
@github-actions github-actions Bot added the t-combinatorics Combinatorics label Jan 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 9, 2026

PR summary 9196e9f909

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance {V : Type u} [DecidableEq V] (r : V → V → Prop)

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@YaelDillies YaelDillies added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jan 9, 2026
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is plenty reasonable, thanks!

maintainer delegate

Comment thread Mathlib/Combinatorics/SimpleGraph/Basic.lean Outdated
@YaelDillies YaelDillies changed the title feat(Combinatorics/SimpleGraph/Basic): Add decidability instance for SimpleGraph.fromRel.Adj feat(Combinatorics/SimpleGraph/Basic): decidability instance for fromRel.Adj Jan 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 9, 2026

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 9, 2026
Paul-Lez and others added 2 commits January 9, 2026 19:48
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jan 10, 2026
@urkud
Copy link
Copy Markdown
Member

urkud commented Jan 12, 2026

Thanks! 🎉
bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jan 12, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jan 12, 2026
…mRel.Adj` (#33798)

This might be better as a definition - I'll let the reviewers weigh in on this.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Jan 12, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(Combinatorics/SimpleGraph/Basic): decidability instance for fromRel.Adj [Merged by Bors] - feat(Combinatorics/SimpleGraph/Basic): decidability instance for fromRel.Adj Jan 12, 2026
@mathlib-bors mathlib-bors Bot closed this Jan 12, 2026
alreadydone pushed a commit to alreadydone/mathlib4 that referenced this pull request Jan 12, 2026
…mRel.Adj` (leanprover-community#33798)

This might be better as a definition - I'll let the reviewers weigh in on this.
eliasjudin pushed a commit to eliasjudin/mathlib4 that referenced this pull request Jan 18, 2026
…mRel.Adj` (leanprover-community#33798)

This might be better as a definition - I'll let the reviewers weigh in on this.
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
…mRel.Adj` (leanprover-community#33798)

This might be better as a definition - I'll let the reviewers weigh in on this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants