[Merged by Bors] - chore(Algebra): move LinearMap.ker_restrictScalars#33788
Closed
harahu wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(Algebra): move LinearMap.ker_restrictScalars#33788harahu wants to merge 1 commit intoleanprover-community:masterfrom
LinearMap.ker_restrictScalars#33788harahu wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
harahu
changed the title
LinearMap.ker_restrictScalars
github-actions
Bot
added
large-import
PR summary 55f4562994
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Module.Submodule.Ker | 642 | 644 | +2 (+0.31%) |
Import changes for all files
| Files | Import difference |
|---|---|
3 filesMathlib.Algebra.Module.Submodule.EqLocus Mathlib.Algebra.Module.Submodule.IterateMapComap Mathlib.Algebra.Module.Submodule.Ker |
2 |
Declarations diff
+ ker_restrictScalars
- LinearMap.ker_restrictScalars
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
harahu
force-pushed
the
chore/move-ker_restrictScalars
branch
from
e088965 to
36c799a
Compare
github-actions
Bot
removed
the
large-import
mathlib4-merge-conflict-bot
added
the
merge-conflict
Collaborator
|
This pull request has conflicts, please merge |
harahu
force-pushed
the
chore/move-ker_restrictScalars
branch
from
36c799a to
f6bb616
Compare
github-actions
Bot
removed
the
merge-conflict
Contributor
Probably fine (especially if you're just moving to a strictly earlier file, since then nothing will break). |
mcdoll
reviewed
Jan 13, 2026
mathlib4-merge-conflict-bot
added
the
merge-conflict
Collaborator
|
This pull request has conflicts, please merge |
harahu
force-pushed
the
chore/move-ker_restrictScalars
branch
from
6e3321e to
e7d6514
Compare
github-actions
Bot
removed
the
merge-conflict
Vierkantor
reviewed
Jan 29, 2026
Contributor
Vierkantor
left a comment
Vierkantor
left a comment
There was a problem hiding this comment.
Thanks for picking this up! I am slightly annoyed that we had to add an extra import. But its impact is very local so I am okay with it.
bors r+
ghost
added
the
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
Resolve an old TODO by moving `LinearMap.ker_restrictScalars` to a location in `Mathlib/Algebra/Module/Submodule`. The TODO referenced lemmas in plural, but only `LinearMap.ker_restrictScalars` seemed to fit. I assume any other lemmas might already have been moved at an earlier point.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
LinearMap.ker_restrictScalarsLinearMap.ker_restrictScalars
YellPika
pushed a commit
to YellPika/mathlib4
that referenced
this pull request
Feb 3, 2026
…unity#33788) Resolve an old TODO by moving `LinearMap.ker_restrictScalars` to a location in `Mathlib/Algebra/Module/Submodule`. The TODO referenced lemmas in plural, but only `LinearMap.ker_restrictScalars` seemed to fit. I assume any other lemmas might already have been moved at an earlier point.
michaellee94
pushed a commit
to michaellee94/mathlib4
that referenced
this pull request
Feb 15, 2026
…unity#33788) Resolve an old TODO by moving `LinearMap.ker_restrictScalars` to a location in `Mathlib/Algebra/Module/Submodule`. The TODO referenced lemmas in plural, but only `LinearMap.ker_restrictScalars` seemed to fit. I assume any other lemmas might already have been moved at an earlier point.
Maldooor
pushed a commit
to Maldooor/mathlib4
that referenced
this pull request
Feb 25, 2026
…unity#33788) Resolve an old TODO by moving `LinearMap.ker_restrictScalars` to a location in `Mathlib/Algebra/Module/Submodule`. The TODO referenced lemmas in plural, but only `LinearMap.ker_restrictScalars` seemed to fit. I assume any other lemmas might already have been moved at an earlier point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve an old TODO by moving
LinearMap.ker_restrictScalarsto a location inMathlib/Algebra/Module/Submodule.The TODO referenced lemmas in plural, but only
LinearMap.ker_restrictScalarsseemed to fit. I assume any other lemmas might already have been moved at an earlier point.Note for reviewers:
Mathlib/Algebra/Module/Submodule/Ker.leanwas chosen somewhat arbitrarily in favor ofMathlib/Algebra/Module/Submodule/RestrictScalars.lean. Please consider whetherKer.leanis the optimal location for this lemma.