Skip to content

[Merged by Bors] - feat(Data/Seq): update and set operations for Seq#26120

Closed
vasnesterov wants to merge 35 commits intoleanprover-community:masterfrom
vasnesterov:vasnesterov/Seq_operations
Closed

[Merged by Bors] - feat(Data/Seq): update and set operations for Seq#26120
vasnesterov wants to merge 35 commits intoleanprover-community:masterfrom
vasnesterov:vasnesterov/Seq_operations

Conversation

@vasnesterov
Copy link
Copy Markdown
Collaborator

@vasnesterov vasnesterov commented Jun 18, 2025

Introduce update and set operations for sequences, along with a few lemmas about them.


Open in Gitpod

This PR continues the work from #20160.

Original PR: #20160

@vasnesterov
Copy link
Copy Markdown
Collaborator Author

Comments from Original PR #20160

This section contains 2 comment(s) from the original PR, excluding bot comments.


@github-actions (2024-12-21 18:00 UTC):
messageFile.md


@github-actions (2025-01-18 19:28 UTC):

PR summary 2d46e13f91

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ modify
+ modify_cons_succ
+ modify_cons_zero
+ modify_nil
+ set
+ set_cons_succ
+ set_cons_zero
+ set_dropn_stable_of_lt
+ set_get_of_not_terminated
+ set_get_of_terminated
+ set_get_stable
+ set_nil

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 20, 2025
@vasnesterov vasnesterov removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 20, 2025
@YaelDillies
Copy link
Copy Markdown
Contributor

Don't forget to resolve the comments you addressed satisfactorily and to the PR title/description!

@vasnesterov vasnesterov changed the title feat(Data/Seq): modify and set operations for Seq feat(Data/Seq): update and set operations for Seq Aug 20, 2025
@vasnesterov
Copy link
Copy Markdown
Collaborator Author

Thank you! Done

@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 20, 2025
@vasnesterov vasnesterov removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 20, 2025
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to use variable (...) in instead (although be careful with the resulting order of arguments)

@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 22, 2025
@vasnesterov vasnesterov removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 22, 2025
@YaelDillies
Copy link
Copy Markdown
Contributor

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 23, 2025
@bryangingechen
Copy link
Copy Markdown
Contributor

Thanks! The file is getting a bit long so we may want to think about splitting this file up into Seq/Defs + Seq/Basic or something like that, but that's for another PR.
bors r+

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Aug 24, 2025
mathlib-bors bot pushed a commit that referenced this pull request Aug 24, 2025
Introduce `update` and `set` operations for sequences, along with a few lemmas about them.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 24, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Seq): update and set operations for Seq [Merged by Bors] - feat(Data/Seq): update and set operations for Seq Aug 24, 2025
@mathlib-bors mathlib-bors bot closed this Aug 24, 2025
pechersky pushed a commit to pechersky/mathlib4 that referenced this pull request Aug 25, 2025
…ommunity#26120)

Introduce `update` and `set` operations for sequences, along with a few lemmas about them.
FormulaRabbit81 pushed a commit to YaelDillies/mathlib4 that referenced this pull request Aug 30, 2025
…ommunity#26120)

Introduce `update` and `set` operations for sequences, along with a few lemmas about them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants