Skip to content

[Merged by Bors] - refactor(Data/Seq): mark Seq.recOn with cases_eliminator#19829

Closed
vasnesterov wants to merge 2 commits intomasterfrom
vasnesterov/Seq_lemmas
Closed

[Merged by Bors] - refactor(Data/Seq): mark Seq.recOn with cases_eliminator#19829
vasnesterov wants to merge 2 commits intomasterfrom
vasnesterov/Seq_lemmas

Conversation

@vasnesterov
Copy link
Copy Markdown
Collaborator

Mark Seq.recOn with cases_eliminator to enable using cases tactic with sequences.


This PR is necessary for my tactic (#18486), which computes the asymptotics of real functions, where I extensively use the cases tactic for sequences. I think it's more readable than apply recOn and behaves better with local hypotheses.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2024

PR summary e7dd2f6928

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Dec 9, 2024
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 22, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 22, 2025
Mark `Seq.recOn` with `cases_eliminator` to enable using `cases` tactic with sequences.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 22, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Data/Seq): mark Seq.recOn with cases_eliminator [Merged by Bors] - refactor(Data/Seq): mark Seq.recOn with cases_eliminator Jan 22, 2025
@mathlib-bors mathlib-bors bot closed this Jan 22, 2025
@mathlib-bors mathlib-bors bot deleted the vasnesterov/Seq_lemmas branch January 22, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants