π‘οΈ Sentinel: [HIGH] Prevent system roles from being updated by tenants#262
π‘οΈ Sentinel: [HIGH] Prevent system roles from being updated by tenants#262ldsgroups225 wants to merge 1 commit intomasterfrom
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
π¨ Severity: HIGH
π‘ Vulnerability: Tenant IDOR / Privilege escalation via
updateRolemodifying global system roles.π― Impact: A malicious tenant could modify the name or permissions of a system-wide role, affecting all schools.
π§ Fix: Added the
isSystemRolecheck to theupdateRolequery handler, throwing a validation error if a tenant attempts to update a system role, matching the logic indeleteRole.β Verification: The
updateRolequery now throws a 'VALIDATION_ERROR' when called on a role whereisSystemRoleis true.PR created automatically by Jules for task 17864447088778841143 started by @ldsgroups225