Conversation
arthurp
reviewed
Apr 3, 2026
Contributor
arthurp
left a comment
arthurp
left a comment
There was a problem hiding this comment.
Nits. Wait for @aneeshdurg for a real review.
| let mut procs: Vec<Arc<Process>> = Vec::new(); | ||
| let initproc = INITPROC.get().expect("initproc not yet initialized"); | ||
| procs.push(initproc.clone()); | ||
| while let Some(proc) = procs.pop() { |
Contributor
There was a problem hiding this comment.
This looks slow. Should it have a TODO to optimize it? (Don't optimize it now.)
Contributor
Author
There was a problem hiding this comment.
Aneesh said to do it this way for now but I can put a todo to fix it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added logic to count the number of hugepages. I tested this with a simple c script that allocates and deallocates hugepages and it seems to count the pages correctly.