Add renderLoading and renderError support for each of gallery items #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroze
reviewed
Jul 2, 2017
| style={{width: layout.width, height: layout.height}} | ||
| source={{uri: pageData}} | ||
| onLoad={this.setLoadedStatus.bind(this, pageId)} | ||
| onError={this.setErrorStatus.bind(this, pageId)}/> |
There was a problem hiding this comment.
It would be great to add a listener on onProgress, that way you could even call renderLoading with the progress. See react-native-image-progress
There was a problem hiding this comment.
Could you look at:
meliorence/react-native-image-gallery#13
p. 5.
This way you can achieve whatever you want with a custom Image component.
It doesn't look like @ldn0x7dc is maintaining this repo and it's dependencies.
|
That would be a very good start! What's your view on this @ldn0x7dc ? |
|
+1 would like this, @ldn0x7dc |
|
@ldn0x7dc Merge this, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in issue #41 =)