Conversation
There was a problem hiding this comment.
Looks good to me, thank you very much for this @liborw.
Just once more as a heads up: your git config does not match your GitHub account, so this contribution may not be displayed under Contributors, also refer https://stackoverflow.com/questions/28141653/does-user-name-in-git-need-to-match-my-github-username.
You may need to configure git config user.email to be associated with your GitHub account.
GitHub also seems to support private emails, also see https://docs.github.com/en/account-and-profile/reference/email-addresses-reference:
Optional: Use GitHub’s private email
If you don’t want to expose your real email, GitHub provides a noreply email like:
12345678+username@users.noreply.github.com
You can configure it the same way:
git config --global user.email "12345678+username@users.noreply.github.com"
If that's fine on your end, I can go ahead. If you wish to create a PR with correct configurations, let me know.
|
/backport |
|
Backport branch created but failed to create PR. (see action log for full response) |
Fixed the MoveIt Servo example, all the parts now run.