Skip to content

Fix moveit servo example#379

Merged
mhubii merged 3 commits intolbr-stack:rollingfrom
rop-ctu:fix/moveit-example-rolling
Mar 11, 2026
Merged

Fix moveit servo example#379
mhubii merged 3 commits intolbr-stack:rollingfrom
rop-ctu:fix/moveit-example-rolling

Conversation

@liborw
Copy link

@liborw liborw commented Mar 10, 2026

Fixed the MoveIt Servo example, all the parts now run.

Copy link
Collaborator

@mhubii mhubii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much for this @liborw.

Just once more as a heads up: your git config does not match your GitHub account, so this contribution may not be displayed under Contributors, also refer https://stackoverflow.com/questions/28141653/does-user-name-in-git-need-to-match-my-github-username.

You may need to configure git config user.email to be associated with your GitHub account.

GitHub also seems to support private emails, also see https://docs.github.com/en/account-and-profile/reference/email-addresses-reference:

Optional: Use GitHub’s private email
If you don’t want to expose your real email, GitHub provides a noreply email like:
12345678+username@users.noreply.github.com
You can configure it the same way:
git config --global user.email "12345678+username@users.noreply.github.com"

If that's fine on your end, I can go ahead. If you wish to create a PR with correct configurations, let me know.

@mhubii mhubii added the enhancement New feature or request label Mar 11, 2026
@mhubii mhubii self-assigned this Mar 11, 2026
@mhubii mhubii mentioned this pull request Mar 11, 2026
@mhubii mhubii merged commit 667d462 into lbr-stack:rolling Mar 11, 2026
1 of 7 checks passed
@mhubii
Copy link
Collaborator

mhubii commented Mar 11, 2026

/backport

@github-actions
Copy link

Backport branch created but failed to create PR.
Request to create PR rejected with status 403.

(see action log for full response)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants