Include component name in path for nested modifications #481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
This addresses #480.
Testing
The parsed template file
templates.jsonnow contains adequate modifier keys:{ "modelicaPath": "Buildings.Templates.AirHandlersFans.VAVMultiZone", "type": "Buildings.Templates.AirHandlersFans.VAVMultiZone", "name": "Multiple-zone VAV", "value": "Buildings.Templates.AirHandlersFans.VAVMultiZone", "visible": false, "modifiers": { "Buildings.Templates.AirHandlersFans.VAVMultiZone.nZon.min": { // Correct for modification 'nZon(min=...)'where it used to be
{ "modelicaPath": "Buildings.Templates.AirHandlersFans.VAVMultiZone", "type": "Buildings.Templates.AirHandlersFans.VAVMultiZone", "name": "Multiple-zone VAV", "value": "Buildings.Templates.AirHandlersFans.VAVMultiZone", "visible": false, "modifiers": { "Buildings.Templates.AirHandlersFans.VAVMultiZone.min": { // Incorrect for modification 'nZon(min=...)'End-to-end tests have been performed by creating the SOO document with the following system options.
AHU
Cooling-only box
The feature branch produces the same document as the main branch.