Skip to content

Fix SSL deprecation, test assertion, and missing mypy dep #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidrecordon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix SSL deprecation, test assertion, and missing mypy dep #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyControl4/director.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ async def _get_session(self) -> AsyncGenerator[aiohttp.ClientSession, None]:
yield self.session
else:
async with aiohttp.ClientSession(
connector=aiohttp.TCPConnector(verify_ssl=False)
connector=aiohttp.TCPConnector(ssl=False)
) as session:
yield session

Expand Down
2 changes: 1 addition & 1 deletion pyControl4/websocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ async def on_clientId(self, client_id: str) -> None:
if not self.connected and not self.subscription_id:
_LOGGER.debug("Fetching subscriptionID from Control4")
session = self.session or aiohttp.ClientSession(
connector=aiohttp.TCPConnector(verify_ssl=False)
connector=aiohttp.TCPConnector(ssl=False)
)
try:
async with asyncio.timeout(10):
Expand Down
1 change: 1 addition & 0 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ python-socketio-v4
websocket-client
pdoc3
pytest-asyncio
mypy
types-xmltodict
2 changes: 1 addition & 1 deletion tests/test_websocket_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,5 @@ async def test_sio_connect_with_session():
connector=mock_connector, connector_owner=False
)
mock_init.assert_called_once_with(
ssl_verify=False, http_session=mock_http_session
ssl_verify=True, http_session=mock_http_session
)
Loading