feat: bump deps#39
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
51-56: Drop the now-unused rollup/babel devDependencies (androllup.config.mjs).The build script switched from
rollup -ctostrapi-plugin build(which uses@strapi/pack-upinternally and derives config frompackage.json#exports). The legacy rollup toolchain (@rollup/plugin-babel,@rollup/plugin-dynamic-import-vars,@rollup/plugin-json,@rollup/plugin-node-resolve,@babel/preset-react) and the existingrollup.config.mjsat the repo root are no longer referenced and just bloat install size while misleading future contributors. Note also thatrollup.config.mjsstill emits toadmin/dist/*, which doesn't match the newdist/admin/*exports — leaving it around is actively confusing.🧹 Proposed cleanup
"devDependencies": { - "@babel/preset-react": "^7.24.7", - "@rollup/plugin-babel": "^6.0.4", - "@rollup/plugin-dynamic-import-vars": "^2.1.2", - "@rollup/plugin-json": "^6.1.0", - "@rollup/plugin-node-resolve": "^15.2.3", "@strapi/sdk-plugin": "^5.4.0" }Also delete
rollup.config.mjsfrom the repo root.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 51 - 56, Remove the unused Rollup/Babel devDependencies listed in package.json (@"@babel/preset-react", "@rollup/plugin-babel", "@rollup/plugin-dynamic-import-vars", "@rollup/plugin-json", "@rollup/plugin-node-resolve") and any related npm script references, and delete the legacy rollup.config.mjs file at the repo root; ensure package.json no longer references these packages or the old "rollup -c" build step so the project relies solely on the current strapi-plugin build flow and exports configuration.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 20: The package currently lists "@strapi/sdk-plugin" in peerDependencies
which is incorrect because it's a dev-only CLI; remove "@strapi/sdk-plugin" from
peerDependencies and add it to devDependencies instead. Edit package.json to
delete the "@strapi/sdk-plugin" entry under peerDependencies and add the same
version string under devDependencies, keeping peerDependencies only for runtime
libs like "@strapi/strapi", "react", "react-dom", "react-router-dom", and
"styled-components".
---
Nitpick comments:
In `@package.json`:
- Around line 51-56: Remove the unused Rollup/Babel devDependencies listed in
package.json (@"@babel/preset-react", "@rollup/plugin-babel",
"@rollup/plugin-dynamic-import-vars", "@rollup/plugin-json",
"@rollup/plugin-node-resolve") and any related npm script references, and delete
the legacy rollup.config.mjs file at the repo root; ensure package.json no
longer references these packages or the old "rollup -c" build step so the
project relies solely on the current strapi-plugin build flow and exports
configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
Please stop @mentioning people multiple times |
Summary by CodeRabbit