Skip to content

feat: bump deps#39

Open
colonder wants to merge 8 commits intolautr:mainfrom
colonder:patch-1
Open

feat: bump deps#39
colonder wants to merge 8 commits intolautr:mainfrom
colonder:patch-1

Conversation

@colonder
Copy link
Copy Markdown

@colonder colonder commented Apr 27, 2026

Summary by CodeRabbit

  • Chores
    • Updated peer dependencies to stable Strapi packages and relaxed React Intl version for compatibility
    • Added React 18 (react/react-dom) and a Strapi SDK plugin as peer dependencies
    • Switched build workflow to Strapi SDK-based scripts and added SDK plugin to dev dependencies
    • Adjusted admin export path and normalized trailing newline

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

Warning

Rate limit exceeded

@colonder has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 44 minutes and 9 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d96b95d3-5447-46b6-a7a6-479ebb625a02

📥 Commits

Reviewing files that changed from the base of the PR and between a54aeab and c07df1d.

📒 Files selected for processing (1)
  • package.json
📝 Walkthrough

Walkthrough

Updated package.json: upgraded Strapi peer dependencies from RC to stable v2/v5 ranges, added react/react-dom and @strapi/sdk-plugin peers, relaxed react-intl, changed exports path for ./strapi-admin, replaced build scripts with Strapi SDK-based commands, and added @strapi/sdk-plugin to devDependencies.

Changes

Cohort / File(s) Summary
Package manifest
package.json
Updated peerDependencies: @strapi/design-system/@strapi/icons^2.0.0, @strapi/strapi/@strapi/utils^5.0.0; added peers react & react-dom ^18.2.0, added @strapi/sdk-plugin ^5.4.0; relaxed react-intl to ^6.6.2; adjusted exports mapping ./strapi-admin to dist/admin/*; replaced rollup -c build script with Strapi SDK-based scripts (watch, watch:link, verify, build as strapi-plugin build); added @strapi/sdk-plugin to devDependencies; normalized trailing newline.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I nibble bytes and hop in cheer,

Versions settled, calm and clear.
Scripts refreshed, exports in line,
SDK added — tidy and fine.
A little newline — perfect rhyme.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'feat: bump deps' is vague and generic, using non-descriptive terms that don't clearly convey the specific changes made to the pull request. Use a more descriptive title that specifies which dependencies were updated or what the main purpose of the changes is, such as 'feat: update Strapi dependencies to stable versions and switch to SDK-based build system'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
package.json (1)

51-56: Drop the now-unused rollup/babel devDependencies (and rollup.config.mjs).

The build script switched from rollup -c to strapi-plugin build (which uses @strapi/pack-up internally and derives config from package.json#exports). The legacy rollup toolchain (@rollup/plugin-babel, @rollup/plugin-dynamic-import-vars, @rollup/plugin-json, @rollup/plugin-node-resolve, @babel/preset-react) and the existing rollup.config.mjs at the repo root are no longer referenced and just bloat install size while misleading future contributors. Note also that rollup.config.mjs still emits to admin/dist/*, which doesn't match the new dist/admin/* exports — leaving it around is actively confusing.

🧹 Proposed cleanup
   "devDependencies": {
-    "@babel/preset-react": "^7.24.7",
-    "@rollup/plugin-babel": "^6.0.4",
-    "@rollup/plugin-dynamic-import-vars": "^2.1.2",
-    "@rollup/plugin-json": "^6.1.0",
-    "@rollup/plugin-node-resolve": "^15.2.3",
     "@strapi/sdk-plugin": "^5.4.0"
   }

Also delete rollup.config.mjs from the repo root.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` around lines 51 - 56, Remove the unused Rollup/Babel
devDependencies listed in package.json (@"@babel/preset-react",
"@rollup/plugin-babel", "@rollup/plugin-dynamic-import-vars",
"@rollup/plugin-json", "@rollup/plugin-node-resolve") and any related npm script
references, and delete the legacy rollup.config.mjs file at the repo root;
ensure package.json no longer references these packages or the old "rollup -c"
build step so the project relies solely on the current strapi-plugin build flow
and exports configuration.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 20: The package currently lists "@strapi/sdk-plugin" in peerDependencies
which is incorrect because it's a dev-only CLI; remove "@strapi/sdk-plugin" from
peerDependencies and add it to devDependencies instead. Edit package.json to
delete the "@strapi/sdk-plugin" entry under peerDependencies and add the same
version string under devDependencies, keeping peerDependencies only for runtime
libs like "@strapi/strapi", "react", "react-dom", "react-router-dom", and
"styled-components".

---

Nitpick comments:
In `@package.json`:
- Around line 51-56: Remove the unused Rollup/Babel devDependencies listed in
package.json (@"@babel/preset-react", "@rollup/plugin-babel",
"@rollup/plugin-dynamic-import-vars", "@rollup/plugin-json",
"@rollup/plugin-node-resolve") and any related npm script references, and delete
the legacy rollup.config.mjs file at the repo root; ensure package.json no
longer references these packages or the old "rollup -c" build step so the
project relies solely on the current strapi-plugin build flow and exports
configuration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: df641eb6-a095-439d-afbc-dfcc59cbb58a

📥 Commits

Reviewing files that changed from the base of the PR and between 778d725 and a54aeab.

📒 Files selected for processing (1)
  • package.json

Comment thread package.json Outdated
@colonder
Copy link
Copy Markdown
Author

@lautr

@jackbuehner
Copy link
Copy Markdown
Collaborator

Please stop @mentioning people multiple times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants