Skip to content

docs(rules): extend gh-json-fields with CI check fields and W23 evidence#1469

Draft
laurigates wants to merge 1 commit into
mainfrom
friction/2026-W23-gh-json-fields
Draft

docs(rules): extend gh-json-fields with CI check fields and W23 evidence#1469
laurigates wants to merge 1 commit into
mainfrom
friction/2026-W23-gh-json-fields

Conversation

@laurigates
Copy link
Copy Markdown
Owner

Summary

W23 friction analysis (week ending 2026-06-01) surfaced 8 Unknown JSON field events across 8 distinct sessions — breaking the zero-hold the rule maintained through W21 and W22. Four of those events tried --json merged again (already documented), but four tried fields the rule did not cover:

Field Sessions Correct lookup
merged on PR 4 state == "MERGED" or mergedAt != null (documented, recurring)
conclusion on PR 2 statusCheckRollup[].conclusion
checksStatus on PR 1 statusCheckRollup[]
issueType on issue 1 issueType.name (documented, but tried as flat field)

The new "CI check fields" section adds statusCheckRollup recipes for the common questions (are all checks passing, which failed, conclusion of one specific check), the full conclusion / status value enums, and a pointer to gh pr checks --required for the lighter exit-code-only path.

This is a pure rule-text extension — no code change, no test infrastructure to touch (regression-testing.md requires a script check only for bug fixes).

Evidence

Findings file: ~/.claude/rules/friction/2026-W23-frictions.md (user-global, not in this repo)

Key drift:

Period Unknown-JSON-field events / sessions
W20 (original rule landed) 10 / 10
W21 0 / 0 (zero-hold)
W22 1 / 1 (zero-hold)
W23 8 / 8 (broken)

Test plan

  • Re-read the rule end-to-end to confirm the CI-check table renders cleanly and the recipes are correct against gh pr view --help output
  • Verify the W24 friction pass (2026-06-08) shows the three new field-name mistakes (conclusion, checksStatus, issueType as flat) drop to zero
  • merged recurrence rate trajectory will indicate whether project-local rule placement is insufficient (next-week decision: promote to user-global ~/.claude/rules/)

Decision context

PR opened by the reduce-friction scheduled task on behalf of feedback-plugin:friction-learner. Per the GitHub Metadata Hygiene rule, the PR author (laurigates) is not added as reviewer because GitHub rejects self-review with HTTP 422.

🤖 Generated with Claude Code

W23 friction analysis (2026-06-01, ending 2026-W23) surfaced 8 new
`Unknown JSON field` events across 8 distinct sessions, breaking the
zero-hold from W21/W22. Fields tried:

| Field | Sessions |
|---|---|
| `merged` on PR | 4 |
| `conclusion` on PR | 2 |
| `checksStatus` on PR | 1 |
| `issueType` on issue | 1 |

`merged` is documented in the existing rule, but `conclusion` and
`checksStatus` (both CI-check fields that live on `statusCheckRollup`,
not flat on the PR object) are new and were not covered. Extending
the rule with a dedicated "CI check fields" section, including:

- The correct `statusCheckRollup` recipes for "are all checks
  passing", "which checks failed", and "conclusion of one specific
  check"
- The full conclusion / status value enumerations
- A pointer to the simpler `gh pr checks --required` exit-code path
  when per-check detail isn't needed

Also refreshed the "The merged mistake" preamble to acknowledge the
W23 reappearance alongside the original W20 evidence.

Evidence: ~/.claude/rules/friction/2026-W23-frictions.md

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@laurigates laurigates added enhancement New feature or request friction-learner Issues filed by the friction-learner agent labels Jun 1, 2026
@laurigates laurigates self-assigned this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request friction-learner Issues filed by the friction-learner agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant