Skip to content

Fourier#45

Open
laurgao wants to merge 6 commits intomainfrom
fourier
Open

Fourier#45
laurgao wants to merge 6 commits intomainfrom
fourier

Conversation

@laurgao
Copy link
Copy Markdown
Owner

@laurgao laurgao commented Jun 20, 2024

piecewise shit is rlly slow rn it seems.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 68.00000% with 40 lines in your changes missing coverage. Please review.

Project coverage is 92.13%. Comparing base (1bdc38c) to head (ee4042f).

Current head ee4042f differs from pull request most recent head 5c77b84

Please upload reports for the commit 5c77b84 to get more accurate results.

Files Patch % Lines
src/simpy/expr.py 66.05% 37 Missing ⚠️
src/simpy/integration.py 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   92.96%   92.13%   -0.83%     
==========================================
  Files          14       14              
  Lines        2871     2989     +118     
==========================================
+ Hits         2669     2754      +85     
- Misses        202      235      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laurgao laurgao requested a review from Copilot June 11, 2025 05:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates test imports to use the new simpy.debug.test_utils package, improves integration handling for piecewise and absolute value expressions, and introduces new Fourier series functionality along with additional transforms such as ExponentialUSub. It also adds several new tests (including for Fourier series, equations, and derivatives) and tweaks internal APIs to better support these new features.

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_trig_simplify.py Updated import for test utilities
tests/test_transforms.py Updated import for test utilities
tests/test_regex.py Updated import for test utilities
tests/test_pts.py Updated import for test utilities
tests/test_nums.py Updated import and removed redundant eq_float definition
tests/test_latex.py Updated import for test utilities
tests/test_khan_academy_integrals.py Updated import and added additional definite integral tests
tests/test_integrals.py Updated import for test utilities
tests/test_fourier.py New file providing Fourier series functionality and its tests
tests/test_exprs.py Updated import and added tests for trigonometric function behavior
tests/test_expand_power.py Updated import for test utilities
tests/test_equation.py New file testing the Equation solver
tests/test_derivatives.py Updated import for test utilities
src/simpy/transforms.py Updated imports, added ExponentialUSub, and modified GenericUSub logic
src/simpy/integration.py Enhanced handling of Piecewise and Abs integration
src/simpy/expr.py Added new properties and adjustments to support Piecewise expressions
src/simpy/equation.py New file for Equation class and its solver
src/simpy/debug/test_utils.py Updated import and added eq_float implementation
Comments suppressed due to low confidence (1)

tests/test_fourier.py:11

  • Consider explicitly passing the Fourier series index (e.g. 'n') as a parameter to get_fourier_series instead of relying on a global definition later in the file; this would make the function interface clearer and reduce potential ambiguity in its usage.
def get_fourier_series(

…licit error handling

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants