refactor: uniform ConfigureAwait(false) on service-layer Task.Run calls#968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Async uniformity from the modernization audit. Library/service code should not capture the synchronization context; most services already use
ConfigureAwait(false)on theirTask.Runcalls, these three were the outliers.refactor:, behavior-preserving, no release.Changes
Task.Run(...)->.ConfigureAwait(false)— the rest of the same method already used it.ConfigureAwait(false). Service mutates a local list and returns it; no UI access on the continuation.CheckErrorLogsAsyncandGetModulesAsync): addedConfigureAwait(false)to theTask.Runblocks.Why uniform, not blanket
Matches the existing convention (EventLogService, PowerShellRunner, ServiceManagerService, SpeedTestService all use
ConfigureAwait(false)onTask.Run). ViewModel continuations that touch the UI keepConfigureAwait(true)— those were left alone.Verification
dotnet build(app + tests): 0 warnings, 0 errors (TreatWarningsAsErrors=true).