refactor: modernize single-element JSON handling and log previously-silent catches#967
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernization sweep — code idiom + exception-handling uniformity.
refactor:, behavior-preserving, no release.Changes
new[] { root }.AsEnumerable()->[root]with an explicitIEnumerable<JsonElement>target type. Same result, idiomatic .NET 10.FileShredderService.EnumerateFilesSafeandAboutViewModel's build-date reader had emptycatch (IOException)/(UnauthorizedAccessException)blocks. They nowLog.Debug(...)like the rest of the codebase (Protocol I: empty catches must log at Debug minimum). Both run once per directory / once per call, so no log flooding.Notes from the audit (deliberately NOT applied)
.Where(...).ToList()->[.. ...]suggestions were skipped: they force avar-> explicit-type rewrite for no real gain and.ToList()is already fine.LatencySeries.ToList().FindIndex(...)was left as-is:ObservableCollection<T>has noFindIndex, so the audit's proposed.FindIndexwould not compile, and the.ToList()is on a cold path.LargeFileScanner's per-directory empty catches were left silent intentionally — that loop walks an entire drive and logging every access-denied would flood the log.Verification
dotnet build(app + tests): 0 warnings, 0 errors.