chore: Use gh-actions/actions/persistent-stores#335
Merged
Conversation
The latest consul image disallowed '$' in the key name. This is causing failing tests since we use an '$inited' key. Until the consul change is remedied, we need to pin to a working version of consul. This is already done in our shared GH action for persistent stores, so I am updating this SDK to finally use that.
jsonbailey
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest consul image incorrectly handles a '$' in the key name.
This is causing failing tests since we use an '$inited' key. Until the
consul change is remedied, we need to pin to a working version
of consul.
This is already done in our shared GH action for persistent stores, so I
am updating this SDK to finally use that.
Note
Switches the build workflow to the shared persistent-stores action and makes a minor spec cleanup.
launchdarkly/gh-actions/actions/persistent-stores@persistent-stores-v0in.github/workflows/build-gem.yml.redis,consul, anddynamodbvia action inputs.spec/ldclient_spec.rb(flags_list.map { |f| f[:key] }.join(", ")).Written by Cursor Bugbot for commit 93ed988. This will update automatically on new commits. Configure here.