Skip to content

Conversation

@keelerm84
Copy link
Member

@keelerm84 keelerm84 commented Jan 30, 2026

Note

Medium Risk
Changes core data-source failover/recovery logic in FDv2, which can affect initialization and update behavior under network failures, though it is covered by updated unit/contract tests.

Overview
Extends Data System synchronization configuration from a fixed primary/secondary model to an ordered list of synchronizers. DataSystemConfig and ConfigBuilder.synchronizers() now accept multiple synchronizer builders (with validation for empty input), and contract-test config parsing is updated to build this list.

FDv2’s synchronizer loop is refactored to iterate/fail over the list (including recovery to the first choice), with an explicit ConditionDirective to differentiate fallback vs recover vs continue decisions; tests are updated/expanded accordingly. CI contract tests are also bumped to v3.0.0-alpha.3 and YAML quoting is normalized.

Written by Cursor Bugbot for commit 8da2666. This will update automatically on new commits. Configure here.

@keelerm84 keelerm84 requested a review from a team as a code owner January 30, 2026 22:25
@keelerm84 keelerm84 force-pushed the mk/sdk-1777/sync-list branch from e1a1a0e to 8da2666 Compare January 30, 2026 22:25
Copy link
Contributor

@jsonbailey jsonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion but don't consider it a blocker.

condition_func: Callable[[DataSourceStatus], bool]
) -> tuple[bool, bool]:
condition_func: Callable[[DataSourceStatus], ConditionDirective]
) -> tuple[bool, bool, ConditionDirective]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Ruby I ended up collapsing this down to a single result, essentially adding the remove sync and fallback as options of the Conditional Directive. From my understanding they are all independent of each other. If you have fallback, you don't care about the other two, if you have remove sync, you don't care about the conditional directive, so there isn't a need to have all three returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants