-
Notifications
You must be signed in to change notification settings - Fork 45
chore: Provide selector for use as basis on FDv2 data sources #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e55dca5 to
9c3cd49
Compare
b57273e to
bf82505
Compare
ldclient/impl/datasystem/store.py
Outdated
| items_decoded[key] = kind.decode(item) | ||
| all_decoded[kind] = items_decoded | ||
| try: | ||
| self._lock.rlock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write lock?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question for all the mutations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That had been fixed in a previous PR. Just needed rebasing.
kinyoklion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locking questions inline.
bf82505 to
a6b2b3d
Compare
Note
Introduces SelectorStore and threads selectors through polling/streaming APIs, FDv2, and tests, including SSE basis query support.
SelectorStoreprotocol and requireselector().Initializer.fetchandSynchronizer.syncsignatures to acceptSelectorStore.PollingDataSource.fetch/sync/_pollto usess.selector()when requesting data.Requester.fetch; no-change/full/changes handling unchanged.SseClientBuilderto take(Config, SelectorStore)and build client with dynamicquery_paramsusing selectorbasis.StreamingDataSource.syncto passSelectorStoreto client builder.SelectorStoreto initializers and synchronizers; consume updates unchanged.fetch(ss),sync(ss),stop()(renamed fromclose).MockSelectorStoreand update all tests to pass aSelectorStore.Written by Cursor Bugbot for commit a6b2b3d. This will update automatically on new commits. Configure here.