feat(server-ai): stamp modelKey and modelVersion on AI usage events (AIC-2851)#208
Open
atornsii wants to merge 2 commits into
Open
feat(server-ai): stamp modelKey and modelVersion on AI usage events (AIC-2851)#208atornsii wants to merge 2 commits into
atornsii wants to merge 2 commits into
Conversation
Read pinned model key/version from the AI Config variation payload and include them on tracker metric events to support version-aware cost attribution. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 8, 2026
Contributor
|
Holding based on our conversation today and we will follow up on slack before reviewing. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a04361b. Configure here.
Older variations are not backfilled with modelVersion, so defaulting to 1 mis-stamped events. Only include the field when the payload provides it and let the backend apply its version-1 fallback on read. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
modelKeyandmodelVersionfrom the AI Config variation payload (variation['model']) and expose them onModelConfigmodelKey(when present) andmodelVersionon allLDAIConfigTrackermetric event payloads, alongside existingmodelName/providerNamefieldsmodelVersionto1when absent, matching variation version handling; exclude both fields from the resumption tokenPart of AIC-2851 / AIC-2849. Depends on backend payload work (AIC-2876) shipping
modelKey/modelVersionon variations.Test plan
uv run pytestinpackages/sdk/server-ai(229 passed)uv run mypy src/ldaiuv run isort --check --atomic src/ldaiuv run pycodestyle src/ldaiMade with Cursor