fix: always return ModelSettings from _build_model_settings#169
Open
jsonbailey wants to merge 1 commit intomainfrom
Open
fix: always return ModelSettings from _build_model_settings#169jsonbailey wants to merge 1 commit intomainfrom
jsonbailey wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if kwargs else Noneguard inOpenAIAgentRunner._build_model_settings()so an emptyModelSettings()is returned instead ofNonewhen no parameters are set.Test plan
OpenAIAgentRunnerworks correctly when no model parameters are configured🤖 Generated with Claude Code
Note
Low Risk
Low risk, localized behavior change that removes a
Nonereturn path; only potential impact is if downstream code relied onmodel_settings=Nonesemantics in the Agents SDK.Overview
Ensures
OpenAIAgentRunner._build_model_settings()always constructs and returnsModelSettings(**kwargs)instead of returningNonewhen no known model parameters are set, so the agent is consistently initialized with aModelSettingsobject.Reviewed by Cursor Bugbot for commit 0138d69. Bugbot is set up for automated code reviews on this repo. Configure here.