fix: grant pull-requests read permission to lint-pr-title workflow#736
Open
abelonogov-ld wants to merge 1 commit into
Open
fix: grant pull-requests read permission to lint-pr-title workflow#736abelonogov-ld wants to merge 1 commit into
abelonogov-ld wants to merge 1 commit into
Conversation
The reusable workflow launchdarkly/gh-actions lint-pr-title.yml requests 'pull-requests: read', but the caller granted 'pull-requests: none', causing a startup failure on PRs (including release-please PRs). Grant the required contents/pull-requests read permissions to the calling job. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
launchdarkly/gh-actions/.github/workflows/lint-pr-title.yml@mainrequestspull-requests: read, but the caller job grantedpull-requests: none, producing a startup failure on PRs (including therelease-pleasePR, e.g. run 29060791953).lint-pr-titlejobcontents: readandpull-requests: readso the nested reusable workflow is allowed to run.Test plan
lint-pr-titlecheck runs successfully on this PR instead of hitting a startup failure.Note
Low Risk
CI-only permission scope change with read-only access; no application or runtime behavior changes.
Overview
Fixes GitHub Actions startup failures on PRs for the
lint-pr-titlecheck by declaring job-level permissions on the caller.The
lint-pr-titlejob now setscontents: readandpull-requests: readbefore invokinglaunchdarkly/gh-actions/.github/workflows/lint-pr-title.yml@main. The reusable workflow expectspull-requests: read, but the caller previously left PR access at the default/none effective level, which blocked the nested workflow from running (including on release-please PRs).Reviewed by Cursor Bugbot for commit 211c6d0. Bugbot is set up for automated code reviews on this repo. Configure here.