Skip to content

fix: [REL-11891]: nextjs css modules styling override bug #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cspath1 merged 5 commits into from
Jan 29, 2026
Merged

fix: [REL-11891]: nextjs css modules styling override bug #559

cspath1 merged 5 commits into from
Jan 29, 2026

Conversation

@pranjal-jately-ld
Copy link
Contributor

@pranjal-jately-ld pranjal-jately-ld commented Jan 29, 2026 •
edited by launchdarkly-upra bot
Loading

Description

What does this PR do?

Fixes a bug where the toolbar's style detection logic was incorrectly capturing Next.js CSS module styles and moving them to the toolbar's shadow DOM, breaking host application CSS.

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation (changes to documentation only)
  • 🔧 Refactor (code change that neither fixes a bug nor adds a feature)
  • 🎨 Style (formatting, missing semicolons, etc; no production code change)
  • ⚡ Performance (code change that improves performance)
  • ✅ Test (adding missing tests, refactoring tests; no production code change)
  • 🔨 Chore (updating grunt tasks, build process, etc; no production code change)

Screenshots/Videos

Related Jira issue: REL-11891: Toolbar styling intercepting/ruining host application styling

@launchdarkly-upra launchdarkly-upra bot changed the title Cspath/rel 11891 styling override bug [REL-11891] Cspath/rel 11891 styling override bug Jan 29, 2026
@pranjal-jately-ld pranjal-jately-ld force-pushed the cspath/REL-11891-styling-override-bug branch from 911ab1e to 49cf656 Compare January 29, 2026 16:23
@pranjal-jately-ld pranjal-jately-ld changed the title [REL-11891] Cspath/rel 11891 styling override bug fix: [REL-11891]: nextjs css modules styling override bug Jan 29, 2026
@pranjal-jately-ld pranjal-jately-ld marked this pull request as ready for review January 29, 2026 16:24
@pranjal-jately-ld pranjal-jately-ld requested a review from a team as a code owner January 29, 2026 16:24
@pranjal-jately-ld pranjal-jately-ld force-pushed the cspath/REL-11891-styling-override-bug branch from 49cf656 to 68dbdba Compare January 29, 2026 16:25
@cspath1 cspath1 merged commit 6564857 into main Jan 29, 2026
4 checks passed
@cspath1 cspath1 deleted the cspath/REL-11891-styling-override-bug branch January 29, 2026 20:05
@github-actions github-actions bot mentioned this pull request Jan 29, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cspath1 cspath1 cspath1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pranjal-jately-ld @cspath1