Skip to content

Conversation

@joker23
Copy link
Contributor

@joker23 joker23 commented Jan 14, 2026

  • Updates the common client typing so evaluation detail properties are optional (better compat)
  • Removes the browser sdk compat module
  • Moved the non-optional evaluation detail type to RN only (to avoid breaking changes)

Note

Aligns evaluation detail typings and removes deprecated browser compat code.

  • Types: Make reason optional in LDEvaluationDetail and LDEvaluationDetailTyped in shared/sdk-client for better compatibility
  • React Native: Add RN-specific LDEvaluationDetail/LDEvaluationDetailTyped (nullable reason) and re-export; update useTypedVariationDetail to use these types
  • Browser SDK: Remove the entire src/compat module, related tests, export entries, and build entry; delete upgrade docs; simplify package.json exports and tsup config

Written by Cursor Bugbot for commit 8c8a043. This will update automatically on new commits. Configure here.

@joker23 joker23 force-pushed the skz/sdk-1725/browser-migration branch from 7cce22d to 254ab72 Compare January 15, 2026 15:51
@joker23 joker23 force-pushed the skz/sdk-1691/remove-browser-compat branch from d9cda1b to 2bfc2e8 Compare January 16, 2026 17:43
@joker23 joker23 changed the title refactor: replace compat module with compat helper fix: evaluation detail type should be optional Jan 16, 2026
@joker23 joker23 marked this pull request as ready for review January 16, 2026 17:51
@joker23 joker23 requested a review from a team as a code owner January 16, 2026 17:51
Base automatically changed from skz/sdk-1725/browser-migration to main January 16, 2026 18:15
@joker23 joker23 force-pushed the skz/sdk-1691/remove-browser-compat branch from 2d147ec to 384093e Compare January 16, 2026 19:46
@github-actions
Copy link
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25394 bytes
Compressed size limit: 26000
Uncompressed size: 124693 bytes

@github-actions
Copy link
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 171362 bytes
Compressed size limit: 200000
Uncompressed size: 798447 bytes

@github-actions
Copy link
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 19354 bytes
Compressed size limit: 20000
Uncompressed size: 99752 bytes

@github-actions
Copy link
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 23335 bytes
Compressed size limit: 25000
Uncompressed size: 81335 bytes

@joker23 joker23 force-pushed the skz/sdk-1691/remove-browser-compat branch from 384093e to 8c8a043 Compare January 16, 2026 19:50
@joker23 joker23 closed this Jan 16, 2026
@joker23 joker23 deleted the skz/sdk-1691/remove-browser-compat branch January 16, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants