Merged
Conversation
aaron-zeisler
changed the base branch from
v7
to
aaronz/update-golangci-lint-version
keelerm84
approved these changes
Feb 19, 2026
aaron-zeisler
changed the title
aaron-zeisler
changed the title
While working with the Go server SDK, I noticed that some tests were intermittently failing in CI. These tests were unrelated to the changes that I was making. After digging into the failures, I found that the failing tests were asserting that an LDClient object was in the "VALID" state immedaitely after initializing the object. In CI, the state was being reported as "INITIALIZING". When I simply re-ran the tests in the CI system, the tests passed. This commit updates tests cases in the end-to-end tests to wait for the LDClient to reach the "VALID" state. I've used the WaitFor() method that's built into the client. The test times out if the client hasn't reached the expected state within 5 seconds.
aaron-zeisler
force-pushed
the
aaronz/fix-flaky-end-to-end-tests
branch
from
55cab1e to
ecedbd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working with the Go server SDK, I noticed that some tests were intermittently failing in CI. These tests were unrelated to the changes that I was making. After digging into the failures, I found that the failing tests were asserting that an LDClient object was in the "VALID" state immedaitely after initializing the object. In CI, the state was being reported as "INITIALIZING". When I simply re-ran the tests in the CI system, the tests passed.
This commit updates tests cases in the end-to-end tests to wait for the LDClient to reach the "VALID" state. I've used the WaitFor() method that's built into the client. The test times out if the client hasn't reached the expected state within 5 seconds.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.
Note
Low Risk
Test-only change that adds bounded waits to avoid timing-related flakes; no production logic is modified.
Overview
Updates several FDv2 end-to-end tests to wait for initialization to complete instead of asserting the data source is immediately
VALIDafter client creation.Each affected test now calls
client.GetDataSourceStatusProvider().WaitFor(interfaces.DataSourceStateValid, 5s)and fails with a clear timeout message if the state never becomesVALID, reducing intermittent CI failures due to startup timing.Written by Cursor Bugbot for commit ecedbd6. This will update automatically on new commits. Configure here.