feat: Implement flag change listener tests in the Go Server SDK#349
Draft
aaron-zeisler wants to merge 3 commits intov7from
Draft
feat: Implement flag change listener tests in the Go Server SDK#349aaron-zeisler wants to merge 3 commits intov7from
aaron-zeisler wants to merge 3 commits intov7from
Conversation
aaron-zeisler
force-pushed
the
aaronz/flag-change-listener-tests
branch
from
1d72e2b to
f0cb6aa
Compare
Add command constants, parameter structs, and the ListenerNotification payload type to support the three new flag change listener commands: registerFlagChangeListener, registerFlagValueChangeListener, and unregisterListener. Also adds the CapabilityFlagChangeListeners constant to service_params.go. No runtime behavior is introduced in this commit; these are pure type definitions that subsequent commits will build on.
Add flag_change_listener.go with a listenerRegistry that manages goroutine-based subscriptions to the SDK's FlagTracker channels. Each registered listener spawns a goroutine that consumes SDK events and POSTs a ListenerNotification JSON payload to the provided callback URI. General flag change listeners support optional key filtering; value change listeners include old and new values in the payload. Wire the three new commands into SDKClientEntity.DoCommand: registerFlagChangeListener, registerFlagValueChangeListener, and unregisterListener. Also calls closeAll() in Close() to cancel all listener goroutines before the SDK client shuts down. The flag-change-listeners capability is not yet advertised, so no test harness tests are run yet.
Add CapabilityFlagChangeListeners to the test service capabilities list. All 8 flag change listener tests pass against the sdk-test-harness.
aaron-zeisler
force-pushed
the
aaronz/flag-change-listener-tests
branch
from
f0cb6aa to
06224bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.