fix: Fix data and target availability for daemon mode#334
Draft
fix: Fix data and target availability for daemon mode#334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adjust FDv1/FDv2 availability logic to properly report Cached/Defaults in daemon/disabled modes, and add/update tests to cover these scenarios.
daemonMode(ExternalUpdatesOnly) and updateDataAvailability()to avoidRefreshedin daemon mode; preferCachedif store initialized, elseDefaults.TargetAvailability()to returnDefaultswhen offline,Cachedin daemon mode, elseRefreshed.daemonMode(no data sources, store present); set during init.DataAvailability()to returnRefreshedwhen selector defined;Cachedwhen store initialized; otherwiseDefaults.TargetAvailability()to returnDefaultswhen disabled,Refreshedwhen data sources configured,Cachedin daemon mode, elseDefaults.internal/datasystem/data_availability_test.go.ldclient_events_test.go,ldclient_external_updates_only_test.go).Written by Cursor Bugbot for commit 1784d36. This will update automatically on new commits. Configure here.