Add flag-and-release-change skill (apply counterpart to should-flag-change)#102
Open
Vadman97 wants to merge 2 commits into
Open
Add flag-and-release-change skill (apply counterpart to should-flag-change)#102Vadman97 wants to merge 2 commits into
Vadman97 wants to merge 2 commits into
Conversation
The "apply" counterpart to the advisory should-flag-change skill: once a PR's change is judged flag-worthy, this skill creates the guarding flag, wires the new path behind it on the PR branch, and registers an automated rollout (create-automated-rollout-config) so the change releases safely on merge. Two-phase plan->implement, portable (public LD MCP + git). Includes references/auto-release.md (release policies, simple vs policy, precedence) and references/pr-wiring.md (three-dot diff, guarding, push). Wires into README + regenerated skills.json. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Skill eval results
Only suites whose source actually changed since their last recorded score were re-run. Soft-failing while we stabilise the baseline. |
Reframe flag-and-release-change as a PR-scoped orchestrator that composes should-flag-change (decide) + launchdarkly-flag-create (create flag & wire code) and adds the unique auto-release step. Delegate flag-creation and per-SDK guarding mechanics to flag-create instead of re-teaching them; slim pr-wiring.md to PR-specific mechanics (three-dot diff, commit/push) and point at flag-create's sdk-evaluation-patterns for guarding. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
feature-flags/flag-and-release-change— the "apply" half of the software-factory flag pipeline, complementing Brad's advisoryshould-flag-change(#101).Where
should-flag-changedecides whether a PR's change should ship behind a flag (read-only), this skill acts on a "yes":create-automated-rollout-config— a per-environment plan (simple= serve true now;policy= on merge, resolve that env's release policy and run the matching immediate/progressive/guarded rollout).It runs plan → implement with a user check-in between, and creates nothing during planning.
Design choices (per @vkorolik)
gitCLI. Nofactory_*tools; no committed.release-flags/manifest.match-release-policies(preview) →create-automated-rollout-config, mirroring the factory'sstartAutomatedRelease/ release-policy semantics (ADR 0002 in launchdarkly-auto-factory).Contents
skills/feature-flags/flag-and-release-change/SKILL.mdreferences/auto-release.md— release policies,simplevspolicy, precedence (overrides → policy → defaults), preview flow.references/pr-wiring.md— clone, three-dot diff, guarding patterns, commit/push to the PR branch.marketplace.json; README skill list + regeneratedskills.json.Validation
python3 scripts/generate_catalog.py— regeneratedskills.json.python3 scripts/validate_skills.py— 46 SKILL.md files validated.Notes
should-flag-changeas the upstream decision step (that path resolves once Add should-flag-change advisory skill + eval suite #101 merges).auto-factory.ymlGitHub Action.🤖 Generated with Claude Code